Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epss mirroring #636

Merged
merged 41 commits into from
Apr 17, 2024
Merged

Epss mirroring #636

merged 41 commits into from
Apr 17, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Mar 25, 2024

Description

EPSS mirroring is still performed by the API server. It should be performed by the mirror-service instead.

Addressed Issue

Closes DependencyTrack/hyades#926

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sahibamittal sahibamittal marked this pull request as ready for review April 2, 2024 09:42
@sahibamittal sahibamittal requested a review from nscuro April 3, 2024 13:40
@sahibamittal sahibamittal requested a review from nscuro April 5, 2024 10:28
Copy link

codacy-production bot commented Apr 5, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.60% (target: -1.00%) 86.79% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0e03953) 18693 14550 77.84%
Head commit (73f74d2) 18640 (-53) 14621 (+71) 78.44% (+0.60%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#636) 106 92 86.79%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Behaves as expected.

Added a few suggestions, but those are not blockers.

nscuro
nscuro previously approved these changes Apr 15, 2024
@nscuro nscuro added this to the 5.5.0 milestone Apr 15, 2024
@nscuro nscuro added the enhancement New feature or request label Apr 15, 2024
@nscuro nscuro merged commit fee43d8 into main Apr 17, 2024
10 checks passed
@nscuro nscuro deleted the epss-mirroring branch April 17, 2024 11:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate EPSS mirroring to mirror-service
2 participants