Fix race condition in doesProjectExist
#601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VithikaS
previously approved these changes
Feb 28, 2024
VithikaS
previously approved these changes
Feb 29, 2024
... by enforcing uniqueness as database constraints, instead of trying to do it in the application code. This bug affects DT v4.x as well, but because we can't create partial indexes there (DataNucleus doesn't give us that much control), we can't really fix it. Fixes DependencyTrack/hyades#1101 Signed-off-by: nscuro <[email protected]>
Tests made bad assumptions about duplicate projects being allowed. Also, remove `JdbiTestUtil` which was only necessary to run JDBI tests with H2. Since we dropped H2, this is no longer required. Signed-off-by: nscuro <[email protected]>
VithikaS
approved these changes
Feb 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes race condition in
doesProjectExistby enforcing uniqueness as database constraints, instead of trying to do it in the application code.Addressed Issue
Fixes DependencyTrack/hyades#1101
Additional Details
This bug affects DT v4.x as well, but because we can't create partial indexes there (DataNucleus doesn't give us that much control), we can't really fix it.
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly