Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced custom Vers with versatile library #598

Merged
merged 7 commits into from
Mar 22, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Feb 27, 2024

Description

While implementing the vulnerability mirroring capability, we wrote our own vers code to deal with version ranges.
Replace the custom vers handling with versatile.

Addressed Issue

Closes DependencyTrack/hyades#1092

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sahibamittal sahibamittal marked this pull request as ready for review February 27, 2024 12:38
@sahibamittal sahibamittal requested a review from nscuro March 1, 2024 10:30
@sahibamittal sahibamittal marked this pull request as draft March 4, 2024 16:24
@nscuro nscuro added this to the 5.5.0 milestone Mar 4, 2024
@sahibamittal sahibamittal marked this pull request as ready for review March 5, 2024 12:25
Copy link

codacy-production bot commented Mar 5, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.05% (target: -1.00%) 93.55% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8ff235b) 18700 14558 77.85%
Head commit (696e4b2) 18586 (-114) 14460 (-98) 77.80% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#598) 31 29 93.55%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@nscuro nscuro added the enhancement New feature or request label Mar 22, 2024
@sahibamittal sahibamittal merged commit cbfb826 into main Mar 22, 2024
9 checks passed
@sahibamittal sahibamittal deleted the issue-1092-replace-custom-vers branch March 22, 2024 17:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace custom vers handling with versatile
2 participants