Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SPDX expressions #393

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Implement SPDX expressions #393

merged 1 commit into from
Oct 26, 2023

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Oct 24, 2023

Description

Implements support for SPDX expressions.

Ported from DependencyTrack/dependency-track#2400

Note: Evaluation of SPDX expressions is not implemented for CEL policies. This will be done separately in DependencyTrack/hyades#872.

Addressed Issue

DependencyTrack/hyades#858

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Ported from DependencyTrack/dependency-track#2400

Note: Evaluation of SPDX expressions is not implemented for CEL policies. This will be done separately in DependencyTrack/hyades#872.

Co-authored-by: Hendrik Borchardt <[email protected]>
Signed-off-by: nscuro <[email protected]>
@nscuro
Copy link
Member Author

nscuro commented Oct 25, 2023

PLEASE DON'T SQUASH MERGE, it would mess up the follow-up PR #396 🙏

Copy link
Collaborator

@sahibamittal sahibamittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sahibamittal sahibamittal merged commit 614213a into main Oct 26, 2023
6 checks passed
@sahibamittal sahibamittal deleted the port-pr2400 branch October 26, 2023 10:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants