Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lib version bump #392

Closed
wants to merge 6 commits into from
Closed

Lib version bump #392

wants to merge 6 commits into from

Conversation

VithikaS
Copy link
Collaborator

@VithikaS VithikaS commented Oct 24, 2023

Description

This PR is for bumping cyclonedx-core-java to 8.0.2 and modifies some tests accordingly

Addressed Issue

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@VithikaS VithikaS added the enhancement New feature or request label Oct 24, 2023
@nscuro
Copy link
Member

nscuro commented Oct 24, 2023

As an alternative to changing the test BOM file, we could shadow this modified HashesDeserializer class: https://github.com/CycloneDX/cyclonedx-core-java/pull/344/files#diff-daaefb64b793634be9006fb0f186681ddc14ea3d40059c105c5dddf02cdca036

Also one test needs adjustment:

Error:  Failures: 
Error:    VexResourceTest.exportProjectAsCycloneDxTest:131 JSON documents are different:
Different value found in node "specVersion", expected: <"1.4"> but was: <"1.5">.

@nscuro
Copy link
Member

nscuro commented Oct 26, 2023

@VithikaS Version 8.0.3 of the lib is now available and should fix the issue you've been encountering: https://central.sonatype.com/artifact/org.cyclonedx/cyclonedx-core-java/versions

@VithikaS
Copy link
Collaborator Author

@VithikaS Version 8.0.3 of the lib is now available and should fix the issue you've been encountering: https://central.sonatype.com/artifact/org.cyclonedx/cyclonedx-core-java/versions

It works, thanks! Created new PR #397 and closing this one (few other unnecessary commits on local branch so closing it)

@VithikaS VithikaS closed this Oct 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2023
@VithikaS VithikaS deleted the lib-version-bump branch February 20, 2024 20:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants