Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pass-through properties for Kafka Streams and Kafka Producer #376

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Oct 20, 2023

Description

Additional properties beyond those defined in ConfigKey can be provided using the alpine.kafka.streams. / ALPINE_KAFKA_STREAMS_ and alpine.kafka.producer. / ALPINE_KAFKA_PRODUCER_ prefixes.

For example, ALPINE_KAFKA_STREAMS_PRODUCER_LINGER_MS=666 sets the linger.ms property of the embedded producer in Kafka Streams to 666.

Addressed Issue

Closes DependencyTrack/hyades#656

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Additional properties beyond those defined in `ConfigKey` can be provided using the `alpine.kafka.streams.` / `ALPINE_KAFKA_STREAMS_` and `alpine.kafka.producer.` / `ALPINE_KAFKA_PRODUCER_` prefixes.

For example, `ALPINE_KAFKA_STREAMS_PRODUCER_LINGER_MS=666` sets the `linger.ms` property of the embedded producer in Kafka Streams to `666`.

Closes DependencyTrack/hyades#656

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added the enhancement New feature or request label Oct 20, 2023
Copy link
Collaborator

@mehab mehab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nscuro nscuro merged commit 5f951a4 into main Oct 21, 2023
6 checks passed
@nscuro nscuro deleted the issue-656 branch October 21, 2023 15:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to configure more Kafka Streams and Kafka Producer properties in API server
2 participants