Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add component age policy #358

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Feature/add component age policy #358

merged 7 commits into from
Oct 19, 2023

Conversation

mehab
Copy link
Collaborator

@mehab mehab commented Oct 18, 2023 •
edited
Loading

Description

Addressed Issue

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@mehab
intermediate commit
a357afe 
Signed-off-by: mehab <[email protected]>
@mehab
custom function added
d362d43 
Signed-off-by: mehab <[email protected]>
@mehab
component age cell policy working
9ae8592 
Signed-off-by: mehab <[email protected]>
@mehab
removed unused property
d4b25c2 
Signed-off-by: mehab <[email protected]>
@mehab
fixed unit tests. Updated existing componentAgePolicyEvaluator to use…
72ac564 
… integrity meta info. Added tests for cel expression for age

Signed-off-by: mehab <[email protected]>
@mehab mehab marked this pull request as ready for review October 19, 2023 11:11
nscuro
nscuro requested changes Oct 19, 2023
View reviewed changes
src/main/java/org/dependencytrack/policy/cel/CelPolicyLibrary.java Outdated Show resolved Hide resolved
src/main/java/org/dependencytrack/policy/cel/CelPolicyQueryManager.java Outdated Show resolved Hide resolved
...ain/java/org/dependencytrack/policy/cel/compat/ComponentAgeCelPolicyScriptSourceBuilder.java Outdated Show resolved Hide resolved
src/main/java/org/dependencytrack/policy/cel/CelPolicyLibrary.java Outdated Show resolved Hide resolved
src/main/proto/org/dependencytrack/policy/v1/policy.proto Outdated Show resolved Hide resolved
src/main/java/org/dependencytrack/policy/cel/CelPolicyEngine.java Outdated Show resolved Hide resolved
src/test/java/org/dependencytrack/policy/cel/mapping/FieldMappingUtilTest.java Show resolved Hide resolved
@mehab mehab requested a review from nscuro October 19, 2023 13:20
@mehab
cleanup
917754e 
Signed-off-by: mehab <[email protected]>
@nscuro nscuro merged commit d150510 into main Oct 19, 2023
6 checks passed
@nscuro nscuro deleted the feature/addComponentAgePolicy branch October 19, 2023 15:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nscuro nscuro nscuro approved these changes

@sahibamittal sahibamittal Awaiting requested review from sahibamittal

@VithikaS VithikaS Awaiting requested review from VithikaS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehab @nscuro