Renamed componentVulnAnalysisCompleteSubject to FindingsSubject for semantic understanding #204
Conversation
Signed-off-by: mehab <[email protected]>
Signed-off-by: mehab <[email protected]>
…erver into feature/vulnAnalysisCompleteNotify
Signed-off-by: mehab <[email protected]>
…erver into feature/vulnAnalysisCompleteNotify
Signed-off-by: mehab <[email protected]>
Signed-off-by: mehab <[email protected]>
Signed-off-by: mehab <[email protected]>
Signed-off-by: mehab <[email protected]>
Signed-off-by: mehab <[email protected]>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| .setUuid(policyViolation.getUuid().toString()) | ||
| .setType(policyViolation.getType().name()) | ||
| .setTimestamp(Timestamp.newBuilder() | ||
| .setSeconds(policyViolation.getTimestamp().getTime() / 1000)) |
There was a problem hiding this comment.
JavaUtilDate: Date has a bad API that leads to bugs; prefer java.time.Instant or LocalDate.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
|
|
||
| return builder.build(); | ||
| } | ||
| private static PolicyViolationAnalysis convert ( final org.dependencytrack.model.ViolationAnalysis analysis){ |
There was a problem hiding this comment.
UnnecessarilyFullyQualified: This fully qualified name is unambiguous to the compiler if imported.
| private static PolicyViolationAnalysis convert ( final org.dependencytrack.model.ViolationAnalysis analysis){ | |
| private static PolicyViolationAnalysis convert ( final ViolationAnalysis analysis){ |
❗❗ 2 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| src/main/java/org/dependencytrack/parser/hyades/NotificationModelConverter.java | 385 |
| src/main/java/org/dependencytrack/parser/hyades/NotificationModelConverter.java | 409 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/DependencyTrack/hyades-apiserver/204.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/DependencyTrack/hyades-apiserver/204.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes |
|
Closing this pull request as not needed |
Description
Renamed componentVulnAnalysisCompleteSubject to FindingsSubject for semantic understanding. This is to complete the changes requested in PR : DependencyTrack/hyades#613
Addressed Issue
Additional Details
Checklist