Hotfix/case studies redesign #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirginiaDooley
force-pushed
the
hotfix/case-studies-redesign
branch
from
ed2a1f2
to
9ff4b30
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #739 +/- ##
=======================================
Coverage 79.08% 79.08%
=======================================
Files 27 27
Lines 545 545
=======================================
Hits 431 431
Misses 114 114
☔ View full report in Codecov by Sentry. |
VirginiaDooley
force-pushed
the
hotfix/case-studies-redesign
branch
3 times, most recently
from
d85696e
to
5fafe77
Compare
VirginiaDooley
commented
Oct 4, 2023
| @@ -1,7 +1,7 @@ | |||
| {% load thumbnail %} | |||
| {% load typogrify_tags %} | |||
| {% if posts %} | |||
| <h2>On the blog</h2> | |||
| {% comment %} <h2>On the blog</h2> {% endcomment %} | |||
There was a problem hiding this comment.
I'd like to use this functionality to DRY up the case study template but it doesn't work if we keep this header or the link to all posts below.
There was a problem hiding this comment.
@Bekabyx any thoughts on this? This template is used as an includes in a few spots.
There was a problem hiding this comment.
I've resolved this by adding a boolean to the context tag to show the header expect for the case studies template.
VirginiaDooley
force-pushed
the
hotfix/case-studies-redesign
branch
from
5fafe77
to
d31866d
Compare
Merged
Bekabyx
approved these changes
Oct 9, 2023
VirginiaDooley
force-pushed
the
hotfix/case-studies-redesign
branch
from
1e6cf2e
to
f99c9da
Compare
- Rename blog tags - Add custom css for tags in a list - Refactor conditional when tags exist
VirginiaDooley
force-pushed
the
hotfix/case-studies-redesign
branch
from
f99c9da
to
19ffe08
Compare
symroe
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://app.asana.com/0/0/1205591250217702/f
Dependent on #738
This work:
I've also included a few fixes following #738