Filter by blog tag #738
Merged
Filter by blog tag #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirginiaDooley
force-pushed
the
hotfix/blog-indexing
branch
from
bea1baf
to
649df43
Compare
VirginiaDooley
force-pushed
the
hotfix/blog-indexing
branch
from
3f9b6e8
to
c88b971
Compare
VirginiaDooley
commented
Oct 4, 2023
| @@ -35,6 +35,14 @@ def get_queryset(self): | |||
| return qs | |||
|
|
|||
|
|
|||
| class TagPostListView(PostListView): | |||
There was a problem hiding this comment.
I created this for clarity as there are multiple for_tag methods throughout.
VirginiaDooley
force-pushed
the
hotfix/blog-indexing
branch
3 times, most recently
from
e8c978a
to
9f09483
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #738 +/- ##
==========================================
+ Coverage 78.57% 79.08% +0.51%
==========================================
Files 27 27
Lines 532 545 +13
==========================================
+ Hits 418 431 +13
Misses 114 114
☔ View full report in Codecov by Sentry. |
VirginiaDooley
force-pushed
the
hotfix/blog-indexing
branch
5 times, most recently
from
4080aca
to
6a44d35
Compare
VirginiaDooley
force-pushed
the
hotfix/blog-indexing
branch
from
6a44d35
to
e0d5307
Compare
symroe
reviewed
Oct 5, 2023
| <span aria-hidden="true">🏷️</span> | ||
| {% for tag in post.tags %} | ||
| <a href="{% url 'hermes_post_list_by_tag' tag %}">{{ tag }}</a>{% if not forloop.last %}, {% endif %} | ||
| {% endfor %} |
There was a problem hiding this comment.
Can you render tags as a ul & li list? And add some CSS to show them inline rather than as a list? This will help screen readers read them out as tags.
There was a problem hiding this comment.
Fixed. Ran Lighthouse and the page scored 100% for navigation.
VirginiaDooley
force-pushed
the
hotfix/blog-indexing
branch
from
e0d5307
to
db55dca
Compare
-Render tags on post list and detail -Fix filtering -Add tags to Post list admin view -Change tag widget to multiselect
VirginiaDooley
force-pushed
the
hotfix/blog-indexing
branch
from
db55dca
to
5d8e588
Compare
Bekabyx
approved these changes
Oct 9, 2023
symroe
reviewed
Oct 9, 2023
| {% if post.tags %} | ||
| <span aria-hidden="true">🏷️</span> | ||
| {% for tag in post.tags %} | ||
| <ul> |
There was a problem hiding this comment.
ul needs to be outside the loop (drive by review!)
There was a problem hiding this comment.
Fixed in #739
VirginiaDooley
added a commit
that referenced
this pull request
Oct 9, 2023
- Rename blog tags - Add custom css for tags in a list - Refactor conditional when tags exist
VirginiaDooley
added a commit
that referenced
this pull request
Oct 10, 2023
- Rename blog tags - Add custom css for tags in a list - Refactor conditional when tags exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #658
-Render tags on post list and detail
-Fix filtering
-Add tags to Post list admin view
-Change tag widget to multiselect with hard coded tag values
To test, edit or create 2 blog post sin the admin view. Choose a common tag for both posts as well as a unique tag for each. Save the posts and view in the list. Click the unique tags to filter.
On blog list
On blog detail
