Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subvert AI objective #2643

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

beck-thompson
Copy link
Contributor

About the PR

Added a new objective that requires you to upload new laws to the AI. They will come in your uplink for free!

Why / Balance

More objectives more fun! This one is probably kind of hard but hopefully fun for most traitors. They could approach it socially, guns blazing, or stealth. All are valid approaches!

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Changelog

🆑

  • add: New subvert AI objective.

@beck-thompson beck-thompson requested review from a team as code owners January 7, 2025 18:40
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: C# Changes any cs files size/M 64-255 lines Changes: Localization Changes any ftl files S: Merge Conflict Fix your PR! labels Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Jan 7, 2025
@Lyndomen
Copy link
Contributor

Lyndomen commented Jan 7, 2025

Direction review, 24 hours!

args.Cancelled = !found;
}

private void OnLawInserted(AILawUpdatedEvent args)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check that the target has StationAiComponent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it slightly differently (I couldn't find a component like that) but It should be good!

Resources/Prototypes/_DV/Objectives/traitor.yml Outdated Show resolved Hide resolved
@deltanedas deltanedas requested a review from a team January 8, 2025 03:56
@Lyndomen
Copy link
Contributor

Lyndomen commented Jan 8, 2025

Howdy! We're gonna ask that we not merge this one quite yet, up until the AI gets a little more defenses. Common feedback we're getting is that the AI is already incredibly easy to target, and incentivizing it more without changes is troublesome.

We'd still very much like this, but not yet!

@beck-thompson
Copy link
Contributor Author

Howdy! We're gonna ask that we not merge this one quite yet, up until the AI gets a little more defenses. Common feedback we're getting is that the AI is already incredibly easy to target, and incentivizing it more without changes is troublesome.

Sounds good! Also, if you could give feedback on what law specifically should be inserted that would be great (See Deltas dementia post #2595 (comment))!

@deltanedas deltanedas added the S: Do Not Merge Don't merge this yet label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Do Not Merge Don't merge this yet S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants