Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin assistant feedback popups #2595

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

beck-thompson
Copy link
Contributor

About the PR

Add feedback popups for the new job!

Technical details

Added a new system to watch for the end of round and send the popups to the assistants themselves, and command.

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

@beck-thompson beck-thompson requested review from a team as code owners January 3, 2025 00:55
@github-actions github-actions bot added size/M 64-255 lines S: Needs Review Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files and removed S: Needs Review labels Jan 3, 2025
@beck-thompson
Copy link
Contributor Author

I don't think the discord channel is set up yet so that needs to be done first obviously!

Copy link
Contributor

@NullWanderer NullWanderer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded bad, you should make this a generic system configured fully through yaml

deltanedas
deltanedas previously approved these changes Jan 3, 2025
@deltanedas
Copy link
Member

it will be reverted after some time anyway doesnt matter

@beck-thompson
Copy link
Contributor Author

Looks like the relay is set up on the servers and discord now! Should be good to merge whenever they are added to all the maps and stuff

@deltanedas
Copy link
Member

wrt antimov see #2329, looking for headmin input here

@beck-thompson
Copy link
Contributor Author

wrt antimov see #2329, looking for headmin input here

I think this is for #2643 right? And yeah, if the board needs to be changed let me know I don't really know the borg laws that well

@deltanedas
Copy link
Member

real and true dementiaposted

@beck-thompson beck-thompson mentioned this pull request Jan 8, 2025
2 tasks
@beck-thompson
Copy link
Contributor Author

Checked it again with the maps (Now that they actually have assistants) and it seems to work properly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants