Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stocks trading #2103

Merged
merged 20 commits into from
Nov 6, 2024
Merged

stocks trading #2103

merged 20 commits into from
Nov 6, 2024

Conversation

MilonPL
Copy link
Member

@MilonPL MilonPL commented Nov 3, 2024

About the PR

Adds stocks trading to the game!

Why / Balance

Mostly a minigame, gives the LO something to do with the money. It has a lot of roleplay potential and isn't just free money, a couple of uses I could think of:

  • Genuine antag strategy to steal the LO's PDA or the cartridge and gamble all of the station's money away instead of just buying stuff like you normally do.
  • Since it updates every 10 minutes, the reporter could make news articles on the stock changes for the crew to see and comment on it. They have the app installed in their PDA but it requires orders access to actually buy or sell.
  • Admins have two new commands to add a custom company and to change a company's value, meaning it could be used for events.

Technic details

  • PriceHistoryTable.cs to generate the table
  • StockTradingUi.cs to handle the UI updates
  • StockTadingUi.xaml.cs to populate Companies and define colors
  • Early merges #33123 from wizden (it will work without it, it's just nice to have proper UI updating)
  • StationStockMarketComponent that's added to the station and contains companies and other data relevant to the system
  • changestockprice and addstockscompany commands that do what they say

everything should be documented idk

Media

Media

image

gambling.mp4

Breaking changes

Changelog

🆑

  • add: Added the StockTrading app to cargo PDAs, available with the Orders access. Gamblers rejoice!

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: UI Changes: C# Changes any cs files Changes: Localization Changes any ftl files labels Nov 3, 2024
@Proxysseia
Copy link

they only go up, foolproof strategy

@deltanedas
Copy link
Member

with roulette you put it all on red
with stocks you put it all on fish inc

@github-actions github-actions bot added the Changes: Sprite Changes any png or json in an rsi label Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

RSI Diff Bot; head commit 0ffef4b merging into ec0962a
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Misc/program_icons.rsi

State Old New Status
stock_trading Added

Resources/Textures/DeltaV/Objects/Devices/cartridge.rsi

State Old New Status
cart-stonk Added

Edit: diff updated after 0ffef4b

@MilonPL MilonPL marked this pull request as ready for review November 4, 2024 02:35
@MilonPL MilonPL requested review from IamVelcroboy and a team as code owners November 4, 2024 02:35
This reverts commit 8681e5a.
This reverts commit 3992ec9.
@MilonPL MilonPL requested a review from deltanedas November 4, 2024 19:36
@MilonPL
Copy link
Member Author

MilonPL commented Nov 4, 2024

@deltanedas reworked the entire thing, i can't wait to know what's wrong with it now
also cleaned up the fucking cartridges.ftl file plz don't kill

Copy link
Contributor

@Colin-Tel Colin-Tel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Well the reason for the call today, John, is that something just came across my desk, John; it is perhaps the best thing I've seen in the last six months. If you have sixty seconds, I'd like to share the idea with you; you got a minute?"

@MilonPL MilonPL merged commit e7065f0 into DeltaV-Station:master Nov 6, 2024
14 checks passed
@FluffMe
Copy link
Contributor

FluffMe commented Nov 7, 2024

STONKS!

LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 11, 2025
* sort of works

* fix

* oh right

* admin abuse

* buy/sell events

* price history, better error handling

* joke

* buying and selling

* access handling

* IT'S FINALLY REAL

* fixes

* AAAAAAAAAAAAAAAAA

* i keep fucking forgetting things

* FUCKING

* move company structs out of the comp

* ok im going to sleep

* Revert "oh right"

This reverts commit 8681e5a.

* Revert "fix"

This reverts commit 3992ec9.

* address reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: UI Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants