fixes

Content.Client/DeltaV/CartridgeLoader/Cartridges/PriceHistoryTable.cs

@@ -7,9 +7,6 @@ namespace Content.Client.DeltaV.CartridgeLoader.Cartridges;
 public sealed class PriceHistoryTable : BoxContainer
 {
     private readonly GridContainer _grid;
-    private static readonly Color PositiveColor = Color.FromHex("#00ff00");
-    private static readonly Color NegativeColor = Color.FromHex("#ff0000");
-    private static readonly Color NeutralColor = Color.FromHex("#ffffff");
 
     public PriceHistoryTable()
     {
@@ -43,12 +40,12 @@ public PriceHistoryTable()
         // Create and apply the style
         var styleBox = new StyleBoxFlat
         {
-            BackgroundColor = Color.FromHex("#1a1a1a"),
+            BackgroundColor = StockTradingUiFragment.BackgroundColor,
             ContentMarginLeftOverride = 6,
             ContentMarginRightOverride = 6,
             ContentMarginTopOverride = 4,
             ContentMarginBottomOverride = 4,
-            BorderColor = Color.FromHex("#404040"),
+            BorderColor = StockTradingUiFragment.BorderColor,
             BorderThickness = new Thickness(1),
         };
 
@@ -106,9 +103,9 @@ public void Update(List<float> priceHistory)
                 StyleClasses = { "LabelSubText" },
                 Modulate = priceChange switch
                 {
-                    > 0 => PositiveColor,
-                    < 0 => NegativeColor,
-                    _ => NeutralColor,
+                    > 0 => StockTradingUiFragment.PositiveColor,
+                    < 0 => StockTradingUiFragment.NegativeColor,
+                    _ => StockTradingUiFragment.NeutralColor,
                 }
             };
 

Content.Client/DeltaV/CartridgeLoader/Cartridges/StockTradingUiFragment.xaml.cs

@@ -9,14 +9,21 @@
 namespace Content.Client.DeltaV.CartridgeLoader.Cartridges;
 
 [GenerateTypedNameReferences]
-public sealed partial class StockTradingUiFragment : BoxContainer
+public sealed class StockTradingUiFragment : BoxContainer
 {
     private readonly Dictionary<string, CompanyEntry> _companyEntries = new();
 
     // Event handlers for the parent UI
     public event Action<string, float>? OnBuyButtonPressed;
     public event Action<string, float>? OnSellButtonPressed;
 
+    // Define colors
+    public static readonly Color PositiveColor = Color.FromHex("#00ff00"); // Green
+    public static readonly Color NegativeColor = Color.FromHex("#ff0000"); // Red
+    public static readonly Color NeutralColor = Color.FromHex("#ffffff"); // White
+    public static readonly Color BackgroundColor = Color.FromHex("#25252a"); // Dark grey
+    public static readonly Color BorderColor = Color.FromHex("#404040"); // Light grey
+
     public StockTradingUiFragment()
     {
         RobustXamlLoader.Load(this);
@@ -61,15 +68,6 @@ private sealed class CompanyEntry
         private readonly LineEdit _amountEdit;
         private readonly PriceHistoryTable _priceHistory;
 
-        // Define colors
-        private static readonly Color PositiveColor = Color.FromHex("#00ff00"); // Green
-        private static readonly Color NegativeColor = Color.FromHex("#ff0000"); // Red
-        private static readonly Color NeutralColor = Color.FromHex("#ffffff"); // White
-        private static readonly Color BackgroundColor = Color.FromHex("#25252a"); // Dark grey
-        private static readonly Color BorderColor = Color.FromHex("#404040"); // Light grey
-
-
-
         public CompanyEntry(string companyName,
             Action<string, float>? onBuyPressed,
             Action<string, float>? onSellPressed)

Resources/Locale/en-US/deltav/cargo/stocks-commands.ftl

@@ -2,5 +2,5 @@ cmd-changestocksprice-desc = Changes a company's stock price to the specified nu
 cmd-changestocksprice-help = changestockprice <Company name> <New price>
 cmd-changestocksprice-failure = Failed to execute command! Invalid company name or the new price exceeds the allowed limit.
 cmd-addstockscompany-desc = Adds a new company to the stocks market.
-cmd-addstockscompany-help = addstockscompany <Company name> <Base price>
+cmd-addstockscompany-help = addstockscompany <Name> <Display name> <Base price>
 cmd-addstockscompany-already-exists = Failed to execute command! Are you sure the company doesn't exist already?

Resources/Locale/en-US/deltav/cartridge-loader/cartridges.ftl

@@ -131,3 +131,4 @@ mail-metrics-money-header = Spesos
 mail-metrics-total = Total
 mail-metrics-progress = {$opened} out of {$total} packages opened!
 mail-metrics-progress-percent = Success rate: {$successRate}%
+stock-trading-program-name = StockTrading

Resources/Prototypes/DeltaV/Entities/Objects/Devices/cartridges.yml

@@ -76,7 +76,7 @@
     ui: !type:StockTradingUi
   - type: StockTradingCartridge
   - type: Cartridge
-    programName: StockTrading
+    programName: stock-trading-program-name
     icon:
       sprite: DeltaV/Misc/program_icons.rsi
       state: stock_trading