Stop modifying upstream .gitignore file and put build artifacts in debian/build/
#230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fact that Debian builds produce extra files in the build directory is a separate concern and should not be managed by .gitignores in upstream directory. Anyways, the list is not going to be complete on most packages, and instead of extending the list, a better practice is to have proper `make clean` rules in the `debian/rules`, or to simply run `git clean -fdx` between builds. Additionally, everyone should be using `gbp pq` to update patches instead of legacy Quilt, so no more `.pc` directories should be generated.
…urces Instead of putting build artifacts in `_build/` at the project root, where they pollute the upstream sources and lure some people to also modify the upstream `.gitignore` file, put it in `debian/build/` along with all other build artifacts that get generated in `debian/`.
zhsj
reviewed
Dec 12, 2024
| @@ -299,7 +300,7 @@ func writeDebianRules(dir string, pkgType packageType) error { | |||
| fmt.Fprintf(f, "#!/usr/bin/make -f\n") | |||
| fmt.Fprintf(f, "\n") | |||
| fmt.Fprintf(f, "%%:\n") | |||
| fmt.Fprintf(f, "\tdh $@ --builddirectory=_build --buildsystem=golang\n") | |||
| fmt.Fprintf(f, "\tdh $@ --builddirectory=debian/build --buildsystem=golang\n") | |||
There was a problem hiding this comment.
NACK. There are already too many packages using that path.
|
This is not an API. There isn't any downside for new packages to use this
clearly cleaner and better way, and old packages are trivial to update, and
testing that the update works correctly is also trivial. The different
gitignore/clean has been used before should not be an argument on its own.
Otherwise no progress could happen, right?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details. This was split out from #225.
You can see this is action at e.g.