Use DEP-14 branch names debian/latest and upstream/latest
#225
Conversation
|
Please allow the CI to run so I can see the result, and give me enough time to fix all errors :) |
It looks like CI did run when you submitted the PR, am I missing something? |
After submission there was a banner stating that "user does not have permissions to trigger the CI" and that my account must be allowlisted. Later seems the CI ran, not sure if somebody did something or not. |
|
I did 😄 |
In DEP-14, the preferred branch name for the Debian packaging target branch is `debian/latest` and the preferred name for the upstream import target branch is `upstream/latest`. Note that the upstream development branch name can be whatever and should stay as it is upstream, typically `main` or `master`. The branch `upstream/latest` should not point to the latest upstream development commit, but to the latest commit that was used as the upstream release that the Debian revision was derived from.
Instead of using various different upstream remote names, use the one and same upstream git remote name consistently. As the name pick `upstreamvcs` just as git-buildpackage does, so that if anybody runs `gbp clone` they will automatically end up with the same git remotes and branches as anyone in to go-team.
|
I tested this manually by running I also added further refinements based on my Debian packaging best practices knowledge. I am even tempted to add a generic Let me know if you want me to split this into multiple separate PRs. |
ottok
force-pushed
the
dep14
branch
2 times, most recently
from
e354493 to
e2bfbec
Compare
|
Thanks for the review @n-peugnet. Add remarks are resolved and branch updated. I also have test binaries available at https://salsa.debian.org/otto/dh-make-golang/-/jobs/6641396/artifacts/browse/debian/output/ in case you want to test how this would behave eventually when the dh-make-golang package in Debian gets updated. |
|
Example output when trying to package Glow: |
Can you add me to the Debian org on GitHub so GitHub knows I am to be trusted?
|
|
From what I understand, some of these change should first be proposed to the team as a whole, since the branch names have already been updated in the past, for example: https://go-team.pages.debian.net/workflow-changes.html About the removal of the |
I split this out into #230. |
When creating a new package, populate the git-buildpackage with additional configs and in-line comments on why and how to use them. This will make go packaging easier, more consistent and more secure as the best practices flow to all packages via good defaults.
|
Seems not all are aware of DEP-14 contents, so I'll re-iterate here the relevant part: Go team policy in 2017 switched to use DEP-14:
In 2017 DEP-14 was still being changed, and later the Debian-wide agreement was that the branch names should be https://dep-team.pages.debian.net/deps/dep14/
This proposal is simply updating the implementation, while the intent of the policy stays the same. |
In DEP-14, the preferred branch name for the Debian packaging target branch is
debian/latestand the preferred name for the upstream import target branch isupstream/latest. Note that the upstream development branch name can be whatever and should stay as it is upstream, typicallymainormaster. The branchupstream/latestshould not point to the latest upstream development commit, but to the latest commit that was used as the upstream release that the Debian revision was derived from.