Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/update dependencies #926

Merged
merged 2 commits into from
Jan 1, 2024
Merged

Chore/update dependencies #926

merged 2 commits into from
Jan 1, 2024

Conversation

tagliala
Copy link
Contributor

No description provided.

@tagliala
Copy link
Contributor Author 

Expected: <form action="/format_things" accept-charset="UTF-8" method="post"                                                          data-client-side-validations="{&quot;html_settings&quot;:{&quot;type&quot;:&quot;ActionView::Helpers::FormBuilder&quot;,&quot;input_tag&quot;:&quot;\u003cdiv class=\&quot;field_with_errors\&quot;\u003e\u003cspan id=\&quot;input_tag\&quot;\u003e\u003c/span\u003e\u003c/div\u003e&quot;,&quot;label_tag&quot;:&quot;\u003cdiv class=\&quot;field_with_errors\&quot;\u003e\u003clabel id=\&quot;label_tag\&quot;\u003e\u003c/label\u003e\u003c/div\u003e&quot;},&quot;number_format&quot;:{&quot;separator&quot;:&quot;.&quot;,&quot;delimiter&quot;:&quot;,&quot;},&quot;validators&quot;:{&quot;format_thing[escaped_space]&quot;:{&quot;format&quot;:[{&quot;message&quot;:&quot;is invalid&quot;,&quot;with&quot;:{&quot;source&quot;:&quot;\\ &quot;,&quot;options&quot;:&quot;&quot;}}]}}}" novalidate="novalidate" id="new_format_thing" class="new_format_thing"><input type="text" name="format_thing[escaped_space]" id="format_thing_escaped_space" /></form>
Actual:   <form class="new_format_thing" id="new_format_thing" action="/format_things" accept-charset="UTF-8" novalidate="novalidate" data-client-side-validations="{&quot;html_settings&quot;:{&quot;type&quot;:&quot;ActionView::Helpers::FormBuilder&quot;,&quot;input_tag&quot;:&quot;\u003cdiv class=\&quot;field_with_errors\&quot;\u003e\u003cspan id=\&quot;input_tag\&quot;\u003e\u003c/span\u003e\u003c/div\u003e&quot;,&quot;label_tag&quot;:&quot;\u003cdiv class=\&quot;field_with_errors\&quot;\u003e\u003clabel id=\&quot;label_tag\&quot;\u003e\u003c/label\u003e\u003c/div\u003e&quot;},&quot;number_format&quot;:{&quot;separator&quot;:&quot;.&quot;,&quot;delimiter&quot;:&quot;,&quot;},&quot;validators&quot;:{&quot;format_thing[escaped_space]&quot;:{&quot;format&quot;:[{&quot;message&quot;:&quot;is invalid&quot;,&quot;with&quot;:{&quot;source&quot;:&quot; &quot;,&quot;options&quot;:&quot;&quot;}}]}}}" method="post"><input type="text" name="format_thing[escaped_space]" id="format_thing_escaped_space" /></form>

Expected: <form action="/format_things" accept-charset="UTF-8" method="post"           data-client-side-validations="{&quot;html_settings&quot;:{&quot;type&quot;:&quot;ActionView::Helpers::FormBuilder&quot;,&quot;input_tag&quot;:&quot;\u003cdiv class=\&quot;field_with_errors\&quot;\u003e\u003cspan id=\&quot;input_tag\&quot;\u003e\u003c/span\u003e\u003c/div\u003e&quot;,&quot;label_tag&quot;:&quot;\u003cdiv class=\&quot;field_with_errors\&quot;\u003e\u003clabel id=\&quot;label_tag\&quot;\u003e\u003c/label\u003e\u003c/div\u003e&quot;},&quot;number_format&quot;:{&quot;separator&quot;:&quot;.&quot;,&quot;delimiter&quot;:&quot;,&quot;},&quot;validators&quot;:{&quot;format_thing[escaped_space]&quot;:{&quot;format&quot;:[{&quot;message&quot;:&quot;is invalid&quot;,&quot;with&quot;:{&quot;source&quot;:&quot;\\ &quot;,&quot;options&quot;:&quot;&quot;}}]}}}" novalidate="novalidate"><input type="text" name="format_thing[escaped_space]" id="format_thing_escaped_space" /></form>
Actual:   <form action="/format_things" accept-charset="UTF-8" novalidate="novalidate" data-client-side-validations="{&quot;html_settings&quot;:{&quot;type&quot;:&quot;ActionView::Helpers::FormBuilder&quot;,&quot;input_tag&quot;:&quot;\u003cdiv class=\&quot;field_with_errors\&quot;\u003e\u003cspan id=\&quot;input_tag\&quot;\u003e\u003c/span\u003e\u003c/div\u003e&quot;,&quot;label_tag&quot;:&quot;\u003cdiv class=\&quot;field_with_errors\&quot;\u003e\u003clabel id=\&quot;label_tag\&quot;\u003e\u003c/label\u003e\u003c/div\u003e&quot;},&quot;number_format&quot;:{&quot;separator&quot;:&quot;.&quot;,&quot;delimiter&quot;:&quot;,&quot;},&quot;validators&quot;:{&quot;format_thing[escaped_space]&quot;:{&quot;format&quot;:[{&quot;message&quot;:&quot;is invalid&quot;,&quot;with&quot;:{&quot;source&quot;:&quot; &quot;,&quot;options&quot;:&quot;&quot;}}]}}}" method="post"><input type="text" name="format_thing[escaped_space]" id="format_thing_escaped_space" /></form>

@tagliala tagliala force-pushed the chore/update-dependencies branch from d99d926 to 0fc67d0 Compare December 24, 2023 16:10
@coveralls
Copy link

coveralls commented Dec 24, 2023 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling c03f7fd on chore/update-dependencies
into e96bd8e on main.

@tagliala
Run tests that were skipped by mistake
2e86cb3 
Fix Minitest/NonExecutableTestMethod
@tagliala tagliala force-pushed the chore/update-dependencies branch 2 times, most recently from 0e7f0b7 to 1d9efda Compare January 1, 2024 11:16
@tagliala
Expect space when regexp has an escaped space
c03f7fd 
Not 100% sure that this is the correct solution, but according to
jaynetics/js_regex@ba77cc4 and the constant
`LITERAL_REQUIRING_ESCAPE_PATTERN`, it appears that space does not need
the escape pattern

Close #927
@tagliala tagliala force-pushed the chore/update-dependencies branch from 1d9efda to c03f7fd Compare January 1, 2024 11:17
@tagliala tagliala merged commit f3a9c02 into main Jan 1, 2024
25 checks passed
@tagliala tagliala deleted the chore/update-dependencies branch January 1, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tagliala @coveralls