Skip to content

Commit

Permalink
Expect space when regexp has an escaped space
Browse files Browse the repository at this point in the history
Not 100% sure that this is the correct solution, but according to
jaynetics/js_regex@ba77cc4 and the constant
`LITERAL_REQUIRING_ESCAPE_PATTERN`, it appears that space does not need
the escape pattern

Close #927
  • Loading branch information
tagliala committed Jan 1, 2024
1 parent 2e86cb3 commit c03f7fd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/action_view/cases/test_form_for_helpers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ def test_field_with_format_space
end

def test_field_with_format_escaped_space
assert_field_with_format_has_source(:escaped_space, '\\ ')
assert_field_with_format_has_source(:escaped_space, ' ')
end

def test_field_with_format_ascii_escape
Expand Down
2 changes: 1 addition & 1 deletion test/action_view/cases/test_form_with_helpers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ def test_form_with_field_with_format_space
end

def test_form_with_field_with_format_escaped_space
assert_field_with_format_has_source(:escaped_space, '\\ ')
assert_field_with_format_has_source(:escaped_space, ' ')
end

def test_form_with_field_with_format_ascii_escape
Expand Down

0 comments on commit c03f7fd

Please sign in to comment.