Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Do not reference rb_gc_force_recycle on Ruby 3.1+ #3578

Merged
merged 2 commits into from
Apr 9, 2024
+4 −1
Merged

[NO-TICKET] Do not reference rb_gc_force_recycle on Ruby 3.1+ #3578

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e33136
[NO-TICKET] Do not reference `rb_gc_force_recycle` on Ruby 3.1+
ivoanjo Apr 9, 2024
0b4fac5
Ignore unused parameter warning in this function
ivoanjo Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ext/datadog_profiling_native_extension/stack_recorder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,10 +918,13 @@ static VALUE _native_debug_heap_recorder(DDTRACE_UNUSED VALUE _self, VALUE recor
#pragma GCC diagnostic push
// rb_gc_force_recycle was deprecated in latest versions of Ruby and is a noop.
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#pragma GCC diagnostic ignored "-Wunused-parameter"
// This method exists only to enable testing Datadog::Profiling::StackRecorder behavior using RSpec.
// It SHOULD NOT be used for other purposes.
static VALUE _native_gc_force_recycle(DDTRACE_UNUSED VALUE _self, VALUE obj) {
rb_gc_force_recycle(obj);
#ifdef HAVE_WORKING_RB_GC_FORCE_RECYCLE
rb_gc_force_recycle(obj);
#endif
return Qnil;
}
#pragma GCC diagnostic pop
Expand Down
Loading