[NO-TICKET] Do not reference rb_gc_force_recycle on Ruby 3.1+
#3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR avoids referencing `rb_gc_force_recycle` on Rubies where this method is a no-op. **Motivation:** This method will be removed in Ruby 3.4 ( ruby/ruby#10324 ) so we should stop referencing it. **Additional Notes:** N/A **How to test the change?** Validate that CI is still green.
AlexJF
approved these changes
Apr 9, 2024
The parameter is expected to be unused on modern Rubies since this function becomes a no-op.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3578 +/- ##
==========================================
- Coverage 98.27% 98.24% -0.03%
==========================================
Files 1274 1254 -20
Lines 75233 74355 -878
Branches 3545 3529 -16
==========================================
- Hits 73934 73052 -882
- Misses 1299 1303 +4 ☔ View full report in Codecov by Sentry. |
ko1
added a commit
to ko1/ruby
that referenced
this pull request
Apr 10, 2024
and declare it will be removed soon. ddtrace is still referes the API and build was failed. See DataDog/dd-trace-rb#3578 Maybe threre are only few users of this C-API now so we can remove it soon.
ko1
added a commit
to ko1/ruby
that referenced
this pull request
Apr 11, 2024
and declare it will be removed soon. ddtrace is still referes the API and build was failed. See DataDog/dd-trace-rb#3578 Maybe threre are only few users of this C-API now so we can remove it soon.
ko1
added a commit
to ruby/ruby
that referenced
this pull request
Apr 11, 2024
and declare it will be removed soon. ddtrace is still referes the API and build was failed. See DataDog/dd-trace-rb#3578 Maybe threre are only few users of this C-API now so we can remove it soon.
artur-intech
pushed a commit
to artur-intech/ruby
that referenced
this pull request
Apr 26, 2024
and declare it will be removed soon. ddtrace is still referes the API and build was failed. See DataDog/dd-trace-rb#3578 Maybe threre are only few users of this C-API now so we can remove it soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR avoids referencing
rb_gc_force_recycleon Rubies where this method is a no-op.Motivation:
This method will be removed in Ruby 3.4
( ruby/ruby#10324 ) so we should stop referencing it.
Additional Notes:
N/A
How to test the change?
Validate that CI is still green.