Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lib injection artifact file permission #3527

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Fix lib injection artifact file permission #3527

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ada0fc
Fix permission
TonyCTHsu Mar 14, 2024
b6fd300
Add comment
TonyCTHsu Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .gitlab/build-deb-rpm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ echo -n "$RUBY_PACKAGE_VERSION" > auto_inject-ruby.version

source common_build_functions.sh

chmod a+r -R ../tmp/*
# The normal settings for /tmp are 1777, which ls shows as drwxrwxrwt. That is wide open.
#
# This gives all users read access, and removes write access for group and others,
# to all files and directories in the tmp directory.
chmod -R a+r,go-w ../tmp/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here explaining what the permission change is accomplishing, so we can reference it in the future?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ../tmp here the same as the top-level /tmp in the root of the filesystem?

If so, should we maybe use a subdirectory of tmp? E.g. so that we don't accidentally package other things that may have left files in /tmp?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ../tmp here the same as the top-level /tmp in the root of the filesystem?

No, this is under the dd-trace-rb


fpm_wrapper "datadog-apm-library-ruby" "$RUBY_PACKAGE_VERSION" \
--input-type dir \
Expand Down
Loading