Fix lib injection artifact file permission #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
reviewed
Mar 15, 2024
| @@ -5,7 +5,7 @@ echo -n "$RUBY_PACKAGE_VERSION" > auto_inject-ruby.version | |||
|
|
|||
| source common_build_functions.sh | |||
|
|
|||
| chmod a+r -R ../tmp/* | |||
| chmod -R a+r,go-w ../tmp/* | |||
There was a problem hiding this comment.
Can you add a comment here explaining what the permission change is accomplishing, so we can reference it in the future?
There was a problem hiding this comment.
Is ../tmp here the same as the top-level /tmp in the root of the filesystem?
If so, should we maybe use a subdirectory of tmp? E.g. so that we don't accidentally package other things that may have left files in /tmp?
There was a problem hiding this comment.
Is ../tmp here the same as the top-level /tmp in the root of the filesystem?
No, this is under the dd-trace-rb
marcotc
approved these changes
Mar 15, 2024
TonyCTHsu
deleted the
tonycthsu/fix-lib-injection-artifact-file-permission
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The change moved the packaging into /tmp the file permissions there default to being wide open. This PR changes the permission to
drwxr-xr-x