Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Bump debase-ruby_core_source dependency to 3.3.0 #3353

Closed
wants to merge 1 commit into from

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Jan 2, 2024

What does this PR do?

This PR bumps our dependency on debase-ruby_core_source to version 3.3.0. This version includes the headers for the recently-released Ruby 3.3.0; up until now we were supporting that Ruby version using a copy of the headers from the preview release.

Motivation:

Use up-to-date headers for profiling on Ruby 3.3.0.

Additional Notes:

I've updated the appraisal gemfiles as well.

How to test the change?

Validate that CI is green.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

@ivoanjo ivoanjo requested a review from a team as a code owner January 2, 2024 11:42
@ivoanjo
Copy link
Member Author

ivoanjo commented Jan 2, 2024

This PR is currently blocked by #3354: it looks like the debase-ruby_core_source 3.3.0 gem is incompatible with some of the Ruby preview/rc builds, which were still getting used by our CI.

Once our master/CI has picked up the stable 3.3 release, I'll rebase this PR on top of it.

**What does this PR do?**

This PR bumps our dependency on `debase-ruby_core_source` to version
3.3.0. This version includes the headers for the recently-released
Ruby 3.3.0; up until now we were supporting that Ruby version using
a copy of the headers from the preview release.

**Motivation:**

Use up-to-date headers for profiling on Ruby 3.3.0.

**Additional Notes:**

I've updated the appraisal gemfiles as well.

**How to test the change?**

Validate that CI is green.
@ivoanjo ivoanjo force-pushed the ivoanjo/bump-debase-ruby-core-source-3_3_0 branch from 989d9ac to 1e9948b Compare January 2, 2024 14:42
@ivoanjo
Copy link
Member Author

ivoanjo commented Jan 2, 2024

Actually the debase-ruby_core_source version 3.3.0 seems to be failing on Ruby 3.3, it appears to be missing header files. I'll move this back to draft and report the issue upstream.

@ivoanjo ivoanjo marked this pull request as draft January 2, 2024 16:28
@ivoanjo
Copy link
Member Author

ivoanjo commented Jan 2, 2024

Reported upstream as ruby-debug/debase-ruby_core_source#10

@ivoanjo
Copy link
Member Author

ivoanjo commented Jan 9, 2024

Replaced with #337

@ivoanjo ivoanjo closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant