Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debase-ruby_core_source should be updated 3.3.0 #3372

Closed
mscrivo opened this issue Jan 8, 2024 · 3 comments · Fixed by #3373
Closed

debase-ruby_core_source should be updated 3.3.0 #3372

mscrivo opened this issue Jan 8, 2024 · 3 comments · Fixed by #3373
Assignees
Labels
bug Involves a bug community Was opened by a community member profiling Involves Datadog profiling

Comments

@mscrivo
Copy link
Contributor

mscrivo commented Jan 8, 2024

in the gemspec. I was going to do this myself and submit a PR but then I saw https://github.com/DataDog/dd-trace-rb/pull/3284/files and figured you have a script to do this quickly and painlessly?

@mscrivo mscrivo added bug Involves a bug community Was opened by a community member labels Jan 8, 2024
@ivoanjo
Copy link
Member

ivoanjo commented Jan 9, 2024

Hey! Thanks for the heads-up :)

Unfortunately we're blocked by ruby-debug/debase-ruby_core_source#10 -- the latest version is missing some headers that were added late in the Ruby 3.3 release cycle.

Without those headers, upgrading to debase-ruby_core_source 3.3.0 breaks dd-trace-rb (see #3353).

Just to double-check, is our usage of 3.2.3 impacting you?

@ivoanjo ivoanjo self-assigned this Jan 9, 2024
@ivoanjo ivoanjo added the profiling Involves Datadog profiling label Jan 9, 2024
@mscrivo
Copy link
Contributor Author

mscrivo commented Jan 9, 2024

Unfortunately we're blocked by ruby-debug/debase-ruby_core_source#10 -- the latest version is missing some headers that were added late in the Ruby 3.3 release cycle.
Without those headers, upgrading to debase-ruby_core_source 3.3.0 breaks dd-trace-rb (see #3353).

Ah thanks for that!

Just to double-check, is our usage of 3.2.3 impacting you?

We thought it was, because we were seeing build failures in dd-trace-rb's native extension, but then we found that we were installing an old version of the debase-ruby_core_source gem explicitly before calling bundle install, as soon as we updated that to version 3.2.3, all was fine with dd-trace-rb during bundle. However, if we try using 3.3.0, then it breaks, probably because of the issue you mentioned above.

@ivoanjo
Copy link
Member

ivoanjo commented Jan 9, 2024

We thought it was, because we were seeing build failures in dd-trace-rb's native extension, but then we found that we were installing an old version of the debase-ruby_core_source gem explicitly before calling bundle install, as soon as we updated that to version 3.2.3, all was fine with dd-trace-rb during bundle. However, if we try using 3.3.0, then it breaks, probably because of the issue you mentioned above.

Ah, got it! Yeah, only 3.2.3 works with the final 3.3.0 release; the previous versions were missing some changes that came late in the 3.3 development cycle.

The fixed version of debase-ruby_core_source already got released so the plan is to have #3373 merged to master and released very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Involves a bug community Was opened by a community member profiling Involves Datadog profiling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants