Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mtl-h update FSP 4122_21 #566

Open
wants to merge 47 commits into
base: dasharo
Choose a base branch
from
Open

Commits on Sep 13, 2024

  1. include/device/pci_ids.h, soc/intel/mtl: add new MTL-P iGPU ID

    Change-Id: I5fde994b9dc05469b08c6a14ecd6b971a25e365f
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a3509fb View commit details
    Browse the repository at this point in the history
  2. soc/intel/common/block/graphics: hook up graphics ops for MTL

    Change-Id: I0626867dc882e77b1b5018b0851ca9a2c9e57ff0
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    0905e63 View commit details
    Browse the repository at this point in the history
  3. soc/intel/mtl: hook up pch_hda_audio_link_hda_enable

    Change-Id: I161febbca12cd116a27167138a6ab523a644763c
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    fe9a0c7 View commit details
    Browse the repository at this point in the history
  4. meteorlake/romstage/fsp_params.c: wire up DMA protection

    Change-Id: I500f4b502e1ac58e437e53bd0e4cb934c7bb3bbc
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    9575a47 View commit details
    Browse the repository at this point in the history
  5. src/soc/intel/meteorlake/chip.c: add missing DPTF device name

    Change-Id: Ib7c537a1e94fdeaabc65fcabeee17fff8a0e753a
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    1b7b2a6 View commit details
    Browse the repository at this point in the history
  6. soc/intel/mtl/chip.c: Add two missing ACPI device names

    Needed for Windows not to BSOD due to malformed ACPI tables.
    
    Change-Id: Id8a8acea43d0d4615fb26ed66fddda2e74ca0f28
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    41ea51f View commit details
    Browse the repository at this point in the history
  7. soc/intel/meteorlake/fsp_params.c: wire up connection manager Kconfig…

    … option
    
    Change-Id: I91d2133bf6a9f2f9ca355f1af2c0d454795d6ef8
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    dd0c6cc View commit details
    Browse the repository at this point in the history
  8. soc/intel/meteorlake/Kconfig: allow FSP-M SOL on non-Chrome

    Change-Id: I082a4459afd80c328c9233b37ddd6f3a2c5bc528
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c84499f View commit details
    Browse the repository at this point in the history
  9. soc/intel/mtl: hook up public ucode

    Change-Id: I16f20956a1490da02acc24156360aef235111494
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    284551b View commit details
    Browse the repository at this point in the history
  10. soc/intel/mtl: enable common VTD block

    Change-Id: I2e05a6f76308b8b89ec9279888ae9fc6a80152a0
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    eec7f2d View commit details
    Browse the repository at this point in the history
  11. 3rdparty/fsp: bump for MTL IoT FSP

    Change-Id: I4c6655eda6729f2c12f99a09174da6ebc2795258
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    89ca27c View commit details
    Browse the repository at this point in the history
  12. 3rdparty/dasharo-blobs: bump for MTL blobs

    Change-Id: If7b6108379828a9032c38417a4b4dc2204c87356
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8654cfc View commit details
    Browse the repository at this point in the history
  13. payloads/external/iPXE/Makefile: bump iPXE rev for i219-lm 20 support

    Change-Id: I820044e39d161c5c993d2cd6bb51bcb56eb9e9ba
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ee70ccb View commit details
    Browse the repository at this point in the history
  14. mb/clevo/mtl-h: add mainboard

    Add Clevo V5x0TU mainboard.
    
    Preliminary support for the dGPU variant (V5x0TNx) is also added, but
    full support will be added in subsequent patches.
    
    Change-Id: Ic4ffba29e50b6bf2ee010d798f7a952d1264f15c
    Signed-off-by: Michał Kopeć <[email protected]>
    Co-authored-by: Michał Żygowski <[email protected]>
    Co-authored-by: Filip Gołaś <[email protected]>
    3 people committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    22cdf41 View commit details
    Browse the repository at this point in the history
  15. payloads/external/edk2/Makefile: don't recurse submodules when cloning

    The submodules are updated in subsequent steps anyway.
    
    Change-Id: I4243ae3862c89306d355c9559708b22cb86f4d44
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    256c816 View commit details
    Browse the repository at this point in the history
  16. drivers/bayhub_lv2: enable ASPM and PM L1.2 substate

    Set the L1 substate optimize register to 0xF, like Insyde does. I don't
    know what exactly that does, but it works :D
    
    Change-Id: I833e2478cccff4c7f711f1b0614c5fcb6513aafa
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    925b970 View commit details
    Browse the repository at this point in the history
  17. ec/system76/ec/acpi: remove nonfunctional power button device

    Change-Id: I39529022821f96bfee6aaaee9cc86072c90393a2
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5e8e990 View commit details
    Browse the repository at this point in the history
  18. lib/smbios.c: fill in BIOS characteristics depending on payload

    Silences a warning from fwupd when booting with EDK2 payload.
    
    Change-Id: I9c7e1f76c1833476b0f88e5a40e888a1721eb1b3
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    059e36e View commit details
    Browse the repository at this point in the history
  19. soc/intel/meteorlake/Makefile.mk: include missing MemInfoHob from ven…

    …dorcode
    
    Change-Id: If7203621e7767bae8ad791947e61e5aefb31bc19
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8592dc5 View commit details
    Browse the repository at this point in the history
  20. vc/intel/fsp/fsp2_0/iot/meteorlake: copy missing IoT headers to new f…

    …older
    
    Change-Id: I780f662d5df516cc46fa6b4ac180e8cbb1c8c8e8
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3830843 View commit details
    Browse the repository at this point in the history
  21. src/soc/intel/meteorlake/Makefile.mk: use missing IoT headers from vc

    Change-Id: I56f3cfdeb2bfc4f07e4595009fa89acbf048da92
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    dc6b94a View commit details
    Browse the repository at this point in the history
  22. soc/intel/common/block/cse: allow CSE telemetry on non-lite CSE SKU

    The CSE MKHI_BUP_COMMON_GET_BOOT_PERF_DATA command is also implemented
    in non-Lite CSE SKUs.
    
    TEST=Boot NovaCustom V540TU (MTL-P / ME Consumer) with
    SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY_V2 selected and check `cbmem -t`:
    
     990:CSME ROM started execution                        0
     944:CSE sent 'Boot Stall Done' to PMC                 34,000
     945:CSE started to handle ICC configuration           172,000 (138,000)
     946:CSE sent 'Host BIOS Prep Done' to PMC             172,000 (0)
     947:CSE received 'CPU Reset Done Ack sent' from PMC   314,000 (142,000)
     991:Die Management Unit (DMU) load completed          360,000 (46,000)
       0:1st timestamp                                     385,844 (25,844)
      11:start of bootblock                                398,796 (12,952)
      12:end of bootblock                                  402,099 (3,302)
      [...]
    
    Change-Id: I3a5b1abd282af9af33cef2371719df4133684a2e
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    f9d5086 View commit details
    Browse the repository at this point in the history
  23. soc/common/smbus: Support reading SPD5 hubs for DDR5

    DDR5 uses a Serial Presence Detect (SPD) with hub function
    (SPD5 hub device) to store the SPD data. The SPD5 hub has 1024 bytes of
    EEPROM (`CONFIG_DIMM_SPD_SIZE=1024`).
    
    Change-Id: Ic5e6c58f255bef86b68ce90a4f853bf4e7c7ccfe
    Co-authored-by: Meera Ravindranath <[email protected]>
    Signed-off-by: Jeremy Soller <[email protected]>
    Signed-off-by: Tim Crawford <[email protected]>
    2 people authored and mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4ff1e7d View commit details
    Browse the repository at this point in the history
  24. soc/intel/mtl: Fill in SPD data on both channels of DDR5 memory

    Apply CB:75284 to Meteor Lake.
    
    CB:52731 introduced support for reading SPD from the EEPROM via SMBus.
    Replace the now unneeded workaround for DDR5 with filling in the correct
    channels for DDR5.
    
    Change-Id: I600d8fd480cb84d5dcb679e4f0bdeeaaebfab386
    Signed-off-by: Jeremy Soller <[email protected]>
    Signed-off-by: Tim Crawford <[email protected]>
    jackpot51 authored and mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e6be757 View commit details
    Browse the repository at this point in the history
  25. soc/intel/meteorlake/Kconfig: select HAVE_INTEL_ME_HAP

    Change-Id: Ibc4e00dec9953a426d8dacf87f3a09c57a80d9e6
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e63027e View commit details
    Browse the repository at this point in the history
  26. soc/intel/common/cse: do not send EOP when CSE in Debug mode

    CSE will not respond to EOP in Debug mode.
    
    Change-Id: Ifba407c52c6384ca7932ce353b1a66d4da3f6661
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    69b5ae4 View commit details
    Browse the repository at this point in the history
  27. soc/intel/mtl: Set HDA subsystem ID during FSP-M

    Intel introduced a new UPD specifically for setting the HDA subsystem ID
    in FSP-M. Using SiSsidTablePtr in FSP-S no longer works as it will be
    locked with a default value of 0 by that point.
    
    Tested on Clevo V560TU with MTL FSP 4122.12 (0D.00.A8.20).
    
    TEST=PCI config space for HDA device has subsystem ID set.
    
    Change-Id: I5e668747d99b955b0a3946524c5918d328b8e1d3
    Signed-off-by: Tim Crawford <[email protected]>
    crawfxrd authored and mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ea0c137 View commit details
    Browse the repository at this point in the history
  28. soc/intel/cmn/ramtop: Refactor MTRR handling for RAMTOP range

    This patch refactors RAMTOP MTRR type selection to address a critical
    NEM logic bug on SoCs with non-power-of-two cache sets. This bug can
    cause runtime hangs when Write Back (WB) caching is enabled.
    
    Workaround: Force MTRR type to WC (Write Combining) on affected SoCs
    when the cache set count is not a power of two.
    
    BUG=b:306677879
    BRANCH=firmware-rex-15709.B
    TEST=Verified boot on google/ovis and google/rex (including Ovis with
    non-power-of-two cache configuration).
    
    Change-Id: Ia9a8f0d37d581b05c19ea7f9b1a07933caa956d4
    Signed-off-by: Subrata Banik <[email protected]>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/81269
    Reviewed-by: Stefan Reinauer <[email protected]>
    Tested-by: build bot (Jenkins) <[email protected]>
    subrata-b authored and mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    7d5c0b3 View commit details
    Browse the repository at this point in the history
  29. arch/x86: Add API to check if cache sets are power-of-two

    Introduce a function to determine whether the number of cache sets is
    a power of two. This aligns with common cache design practices that
    favor power-of-two counts for efficient indexing and addressing.
    
    BUG=b:306677879
    BRANCH=firmware-rex-15709.B
    TEST=Verified functionality on google/ovis and google/rex (including
    a non-power-of-two Ovis configuration).
    
    Change-Id: I819e0d1aeb4c1dbe1cdf3115b2e172588a6e8da5
    Signed-off-by: Subrata Banik <[email protected]>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/81268
    Reviewed-by: Stefan Reinauer <[email protected]>
    Tested-by: build bot (Jenkins) <[email protected]>
    subrata-b authored and mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    1ab00ab View commit details
    Browse the repository at this point in the history
  30. soc/intel/mtl: Enable RAMTOP caching at SoC level for MTL devices

    This patch enables the `SOC_INTEL_COMMON_BASECODE_RAMTOP` configuration
    at the SoC level for all MTL devices. This change streamlines the
    configuration process, avoiding redundant selections on individual
    mainboards.
    
    BUG=b:306677879
    BRANCH=firmware-rex-15709.B
    TEST=Verified boot functionality on google/ovis and google/rex.
    
    Change-Id: I3aa3a83c190d0a0e93c267222a9dca0ac7651f9c
    Signed-off-by: Subrata Banik <[email protected]>
    Reviewed-on: https://review.coreboot.org/c/coreboot/+/81271
    Tested-by: build bot (Jenkins) <[email protected]>
    Reviewed-by: Stefan Reinauer <[email protected]>
    subrata-b authored and mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    72ccba4 View commit details
    Browse the repository at this point in the history
  31. soc/intel/meteorlake/acpi/pcie.asl: add stubs for SRAM and HEC1 devices

    Change-Id: I702013a6532534bf4fffa824bfd8e4a550abdd3a
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6738d8c View commit details
    Browse the repository at this point in the history
  32. vc/dasharo: Add API to get active cores and HT

    Change-Id: Ia3c6a35e5b37fb1a33cbf69c177b37298e04321e
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 authored and mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ef24096 View commit details
    Browse the repository at this point in the history
  33. soc/intel: Disable RAMTOP caching for non-ChromeOS builds

    Caching the RAMTOP causes issues with FSP MemoryInit for platforms
    with DIMM modules. When memories are swapped, the training may
    sometimes hang randomly. Seems to be a manifestation of the issue
    described here: https://review.coreboot.org/c/coreboot/+/81269/
    (despite the L3 cache sets is power of 2 on the tested i5-1235U SKU).
    
    Disabling the RAMTOP caching make the memory training reliable no
    matter how many times the DIMM modules are swapped/changed in slots.
    
    RAMTOP was designed primarily for boot time optimizations in mind
    (most likely for Chromebooks), so disable the RAMTOP caching for all
    non-ChromeOS builds to boot reliably.
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 authored and mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    1072114 View commit details
    Browse the repository at this point in the history
  34. soc/intel/mtl/romstage/fsp_params.c: disable MRC fastboot on RTC failure

    This is a workaround for modules that don't correctly populate the
    serial number field in SPD.
    
    When such modules are swapped, they generate the same CRC, causing FSP
    to mistakenly consider them the same, and attempt to restore cached MRC
    settings. This won't work when the modules are different.
    
    As a workaround, force retrain the memory when RTC failure is detected.
    Users are expected to reset their CMOS upon changing memory modules.
    
    Change-Id: Iebb2810914b728317ce5ebd84b61667d2ba10529
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5760bcd View commit details
    Browse the repository at this point in the history
  35. src/soc/intel/meteorlake/Kconfig: disable early SOL

    Doesn't work with any FSP revs tested so far.
    
    Change-Id: Ifd112230cdfc645e68f2146677008b200ae1b0a3
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c99b2ab View commit details
    Browse the repository at this point in the history
  36. ec/system76/ec/acpi/s76.asl: use a real ACPI PNP ID

    Change-Id: Iae4bb0965aee8dad819320570b1852939a6ecab7
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    453bfef View commit details
    Browse the repository at this point in the history
  37. soc/intel/meteorlake: hook up graphics ops

    Change-Id: I4843ed215bff8a003799b399885950e69d1daf4d
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    bde7fd1 View commit details
    Browse the repository at this point in the history
  38. ec/system76: add delays in EC update

    Change-Id: I16517f3b76cf706650adafbe38af1d280b4d2f3d
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    da3c1e1 View commit details
    Browse the repository at this point in the history
  39. payloads/external/edk2: Add option to use platform lid library for GOP

    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 authored and mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d7589e9 View commit details
    Browse the repository at this point in the history
  40. soc/intel/common/block/cse/cse_eop.c: join userfacing strings to sing…

    …le lines
    
    Rationale: coreboot coding style guidelines
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    9d7ef7d View commit details
    Browse the repository at this point in the history
  41. .github/workflows/build.yml: obtain novacustom-blobs

    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3b54914 View commit details
    Browse the repository at this point in the history
  42. mb/clevo/mtl-h/ramstage.c: remove duplicated final newline

    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    0e85b4d View commit details
    Browse the repository at this point in the history
  43. configs/config.novacustom_v5.0tu: unify config across variants

    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    7ea10b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. soc/intel/cmn/blk/smbus/smbuslib.c: switch_page: rename offset variable

    Rename to page_ptr which more closely aligns with the SPD5 spec.
    
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c812b8e View commit details
    Browse the repository at this point in the history
  2. soc/intel/cmn/blk/smbus/smbuslib.c: get_spd: reduce if nesting

    Reduce amount of nested if statements by adding separate branches for
    DDR5, DDR4 and older SPD variants.
    
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5ee9aa0 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. src/include/spd_bin.h: introduce SPD_LEN_DDR5

    DDR5 SPD page length is 1024 bytes.
    
    Signed-off-by: Michał Kopeć <[email protected]>
    mkopec committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    bd6336a View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. .github/workflows/build.yml: Update FSP to 4122_21

    Signed-off-by: Filip Gołaś <[email protected]>
    philipandag committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6ee2502 View commit details
    Browse the repository at this point in the history