Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding semver #230

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Adding semver #230

merged 1 commit into from
Sep 3, 2020

Conversation

ineiti
Copy link
Collaborator

@ineiti ineiti commented Aug 28, 2020 •
edited
Loading

Adds the semver class with its tests.
See #226

  • replace == in the tests with equal()
  • add small comment to the regexp: it comes from the official website, allows for prepended android|ios, and minor/patch are optional

Instead of merge, this should be rebased.

Once this is merged, #213 and #215 need to be rebased on this.

@ineiti ineiti self-assigned this Aug 28, 2020
@ineiti ineiti changed the base branch from develop to im-cleanup August 28, 2020 13:26
@ineiti ineiti changed the base branch from im-cleanup to develop August 28, 2020 13:36
@ineiti ineiti mentioned this pull request Aug 28, 2020
Closed
2 tasks
@ineiti ineiti changed the base branch from develop to im-cleanup August 28, 2020 13:39
@ineiti ineiti mentioned this pull request Sep 1, 2020
Closed
4 tasks
@ineiti ineiti marked this pull request as draft September 1, 2020 07:10
Base automatically changed from im-cleanup to develop September 1, 2020 09:30
@ineiti ineiti marked this pull request as ready for review September 1, 2020 09:31
@ineiti ineiti force-pushed the im-semver branch 2 times, most recently from 1b6b300 to 8387381 Compare September 1, 2020 09:47
@ubhaller
Copy link
Contributor

ubhaller commented Sep 2, 2020

@ineiti I added some additional assertions in the SemverTests, would you like me to ammend the changes to 8387381?

@ineiti
Copy link
Collaborator Author

ineiti commented Sep 3, 2020

@ubhaller - yes, that would be nice. Then this PR should go in...

@ineiti @ubhaller
Adding semver
2c76310 
Adds the semver class with its tests.
See #226

Once this is merged, #213 and #215 need to be rebased on this.
@sonarcloud
Copy link

sonarcloud bot commented Sep 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@martinalig martinalig merged commit 104aab7 into develop Sep 3, 2020
@martinalig martinalig deleted the im-semver branch September 3, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinalig martinalig martinalig approved these changes

Assignees

@ineiti ineiti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ineiti @ubhaller @martinalig