Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR 213 #226

Closed
2 tasks done
ineiti opened this issue Aug 28, 2020 · 0 comments
Closed
2 tasks done

Update PR 213 #226

ineiti opened this issue Aug 28, 2020 · 0 comments
Assignees
@ineiti

Comments

@ineiti
Copy link
Collaborator

ineiti commented Aug 28, 2020 •
edited
Loading

  • apply linting and force-push to feature/insert_manager to overwrite g811a8d461394eecd25bd190c01b933cc177b7d05
  • separate into different branches:
    • Cleanup
    • feature/semver
    • feature/insert_manager - depends on feature/semver

Now #213 depends on #229 and #230, so:

  1. first REBASE Cleanups from feature/insert-manager #229 and Adding semver #230 into develop
  2. then, once Feature/insert manager #213 is ready, REBASE Feature/insert manager #213 into develop
@ineiti ineiti self-assigned this Aug 28, 2020
ineiti added a commit that referenced this issue Aug 28, 2020
@ineiti
Feature/insert manager
2f12f1f 
This PR simplifies the controller logic by introducing a new class InsertManager.
InsertManager holds a list of possible Filters which filter keys based on OS, AppVersion or features activated.
The Filters are added at startup in the WSBaseConfig and allow for Filter activation by Profile or Property.

Additionally, the InsertManager can be configured with modifiers.
Modifiers can be used to modify keys before inserting into the datbase.

Replaces the previous g811a8d461394eecd25bd190c01b933cc177b7d05, according to #226
ineiti added a commit that referenced this issue Aug 28, 2020
@ineiti
Feature/insert manager
fdaa883 
This PR simplifies the controller logic by introducing a new class InsertManager.
InsertManager holds a list of possible Filters which filter keys based on OS, AppVersion or features activated.
The Filters are added at startup in the WSBaseConfig and allow for Filter activation by Profile or Property.

Additionally, the InsertManager can be configured with modifiers.
Modifiers can be used to modify keys before inserting into the datbase.

Replaces the previous #811a8d461394eecd25bd190c01b933cc177b7d05, according to #226
ineiti added a commit that referenced this issue Aug 28, 2020
@ineiti
Feature/insert manager
52e5bb6 
This PR simplifies the controller logic by introducing a new class InsertManager.
InsertManager holds a list of possible Filters which filter keys based on OS, AppVersion or features activated.
The Filters are added at startup in the WSBaseConfig and allow for Filter activation by Profile or Property.

Additionally, the InsertManager can be configured with modifiers.
Modifiers can be used to modify keys before inserting into the datbase.

Replaces the previous #811a8d461394eecd25bd190c01b933cc177b7d05, according to #226
ineiti added a commit that referenced this issue Aug 28, 2020
@ineiti
Cleanups from feature/insert-manager
f3595e2 
This is the first PR to make the PR #213 somewhat smaller and more manageable.
It takes only the cleanup parts of it.
See #226
@ineiti ineiti mentioned this issue Aug 28, 2020
Merged
ineiti added a commit that referenced this issue Aug 28, 2020
@ineiti
Adding semver
984e49b 
Adds the semver class with its tests.
See #226

Once this is merged, #213 and #215 need to be rebased on this.
@ineiti ineiti mentioned this issue Aug 28, 2020
Merged
2 tasks
@ubamrein ubamrein mentioned this issue Aug 28, 2020
Merged
3 tasks
ineiti added a commit that referenced this issue Aug 28, 2020
@ineiti
Adding semver
1074949 
Adds the semver class with its tests.
See #226

Once this is merged, #213 and #215 need to be rebased on this.
ineiti added a commit that referenced this issue Aug 28, 2020
@ineiti
Feature/insert-manager
9cabe4d 
This PR simplifies the controller logic by introducing a new class InsertManager.
InsertManager holds a list of possible Filters which filter keys based on OS, AppVersion or features activated.
The Filters are added at startup in the WSBaseConfig and allow for Filter activation by Profile or Property.

Additionally, the InsertManager can be configured with modifiers.
Modifiers can be used to modify keys before inserting into the datbase.

Replaces the previous g811a8d461394eecd25bd190c01b933cc177b7d05, according to #226
ineiti added a commit that referenced this issue Aug 28, 2020
@ineiti
Adding semver
c9f7bd7 
Adds the semver class with its tests.
See #226

Once this is merged, #213 and #215 need to be rebased on this.
ineiti added a commit that referenced this issue Aug 28, 2020
@ineiti
Feature/insert-manager
0ce2d65 
This PR simplifies the controller logic by introducing a new class InsertManager.
InsertManager holds a list of possible Filters which filter keys based on OS, AppVersion or features activated.
The Filters are added at startup in the WSBaseConfig and allow for Filter activation by Profile or Property.

Additionally, the InsertManager can be configured with modifiers.
Modifiers can be used to modify keys before inserting into the datbase.

Replaces the previous g811a8d461394eecd25bd190c01b933cc177b7d05, according to #226
ineiti added a commit that referenced this issue Aug 28, 2020
@ineiti
Feature/insert-manager
aff0d7b 
This PR simplifies the controller logic by introducing a new class InsertManager.
InsertManager holds a list of possible Filters which filter keys based on OS, AppVersion or features activated.
The Filters are added at startup in the WSBaseConfig and allow for Filter activation by Profile or Property.

Additionally, the InsertManager can be configured with modifiers.
Modifiers can be used to modify keys before inserting into the datbase.

Replaces the previous g811a8d461394eecd25bd190c01b933cc177b7d05, according to #226
@ineiti ineiti closed this as completed Sep 1, 2020
ineiti added a commit that referenced this issue Sep 1, 2020
@ineiti
Feature/insert-manager
5bb23a1 
This PR simplifies the controller logic by introducing a new class InsertManager.
InsertManager holds a list of possible Filters which filter keys based on OS, AppVersion or features activated.
The Filters are added at startup in the WSBaseConfig and allow for Filter activation by Profile or Property.

Additionally, the InsertManager can be configured with modifiers.
Modifiers can be used to modify keys before inserting into the datbase.

Replaces the previous g811a8d461394eecd25bd190c01b933cc177b7d05, according to #226
martinalig pushed a commit that referenced this issue Sep 1, 2020
@ineiti @martinalig
Cleanups from feature/insert-manager
694c6a2 
This is the first PR to make the PR #213 somewhat smaller and more manageable.
It takes only the cleanup parts of it.
See #226
ineiti added a commit that referenced this issue Sep 1, 2020
@ineiti
Adding semver
1b6b300 
Adds the semver class with its tests.
See #226

Once this is merged, #213 and #215 need to be rebased on this.
ineiti added a commit that referenced this issue Sep 1, 2020
@ineiti
Adding semver
8387381 
Adds the semver class with its tests.
See #226

Once this is merged, #213 and #215 need to be rebased on this.
ineiti added a commit that referenced this issue Sep 1, 2020
@ineiti
Feature/insert-manager
3ade912 
This PR simplifies the controller logic by introducing a new class InsertManager.
InsertManager holds a list of possible Filters which filter keys based on OS, AppVersion or features activated.
The Filters are added at startup in the WSBaseConfig and allow for Filter activation by Profile or Property.

Additionally, the InsertManager can be configured with modifiers.
Modifiers can be used to modify keys before inserting into the datbase.

Replaces the previous g811a8d461394eecd25bd190c01b933cc177b7d05, according to #226
ineiti added a commit that referenced this issue Sep 1, 2020
@ineiti
Feature/insert-manager
0c9f57b 
This PR simplifies the controller logic by introducing a new class InsertManager.
InsertManager holds a list of possible Filters which filter keys based on OS, AppVersion or features activated.
The Filters are added at startup in the WSBaseConfig and allow for Filter activation by Profile or Property.

Additionally, the InsertManager can be configured with modifiers.
Modifiers can be used to modify keys before inserting into the datbase.

Replaces the previous g811a8d461394eecd25bd190c01b933cc177b7d05, according to #226
ubhaller pushed a commit that referenced this issue Sep 3, 2020
@ineiti @ubhaller
Adding semver
2c76310 
Adds the semver class with its tests.
See #226

Once this is merged, #213 and #215 need to be rebased on this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ineiti ineiti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ineiti