PHPstan annotations for ExternalContestSource Service #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
force-pushed
the
phpstan_baseline_externalsource
branch
2 times, most recently
from
a76e7c2 to
177f665
Compare
nickygerritsen
approved these changes
Feb 11, 2024
If we would make edgecases for all situations every field would become optional.
When CLICS has some extra fields those are now added for documentation.
Only if there are many of those they've been left out.
I've assumed that we can import runs which are still running so the
{run_, contest_ & ''}time are still null so can even have been ommited.
It seems that both runner & compiler are optional based on the examples
in the CLICS documentation.
vmcj
force-pushed
the
phpstan_baseline_externalsource
branch
from
177f665 to
83a2752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think most of those events should be translated to DTOs but for now I prefer to have the file cleaned.
This PR does add some actual functional changes, where possible I've put those in separate commits.