The externalid should be string|null

In practice we would only get that in case that we shadow a shadow.
DOMjudge · Feb 11, 2024 · 177f665 · 177f665
1 parent 03fb283
commit 177f665
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/webapp/src/Service/ExternalContestSourceService.php b/webapp/src/Service/ExternalContestSourceService.php
@@ -605,7 +605,7 @@ protected function loadContest(): void
      *                           id: string, judgement_id?: string, judgement_type_id: string|null,
      *                           max_run_time?: float|null, start_time: string, start_contest_time?: string,
      *                           end_time?: string|null, end_contest_time?: string|null, submission_id: string,
-     *                           output_compile_as_string: null, language_id?: string, externalid?: null,
+     *                           output_compile_as_string: null, language_id?: string, externalid?: string|null,
      *                           team_id: string, problem_id?: string, entry_point?: string|null, old_result?: null,
      *                           files?: array{href: string}}|mixed[]
      *             } $event
@@ -1864,7 +1864,7 @@ protected function processPendingEvents(string $type, string|int $id): void
      *              id: string, judgement_id?: string, judgement_type_id?: string|null,
      *              max_run_time?: float|null, start_time?: string, start_contest_time?: string,
      *              end_time?: string|null, end_contest_time?: string|null, submission_id?: string,
-     *              output_compile_as_string?: null, language_id?: string, externalid?: null,
+     *              output_compile_as_string?: string|null, language_id?: string, externalid?: string|null,
      *              team_id?: string, problem_id?: string, entry_point?: string|null, old_result?: null,
      *              files?: array<array{href: string, filename: string, mime?: string}>} $data
      */
@@ -2102,7 +2102,7 @@ protected function removeWarning(string $entityType, ?string $entityId, string $
      *                           id: string, judgement_id?: string, judgement_type_id: string|null,
      *                           max_run_time?: float|null, start_time: string, start_contest_time?: string,
      *                           end_time?: string|null, end_contest_time?: string|null, submission_id?: string,
-     *                           output_compile_as_string: null, language_id?: string, externalid?: null,
+     *                           output_compile_as_string: null, language_id?: string, externalid?: string|null,
      *                           team_id: string, problem_id?: string, entry_point?: string|null, old_result?: null,
      *                           files?: array{href: string}}|mixed[]
      *             } $event