Remove ignored PHPstan found issues #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
force-pushed
the
clean_baseline_20240203
branch
from
795e7e4 to
6c21d59
Compare
nickygerritsen
approved these changes
Feb 10, 2024
We don't store the result for the statistics (there we only pick valid judgings) but do display judgings which can be aborted. This adds a color for it.
Verified by looking at the code or dumping one of the resulting objects.
If we can have:
array{0_string, ?, 1_string?: ?...} so array of length 3 but with
strings as index we can further limit some of those findings.
We remove the rank if you're not in the top x%, which leads to the empty
string instead of rank number
For the problems we have a copy of the overall array in one key as we
allow different formats. This can be simplified.
This is always going to be ugly as the event can have different shapes even within the same EventFeedFormat, together with the minor changes between formats.
vmcj
force-pushed
the
clean_baseline_20240203
branch
from
6c21d59 to
358684e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nickygerritsen can you look at f1626e2