Based on dump/reading the code

DOMjudge · Feb 8, 2024 · 795e7e4 · 795e7e4
1 parent 50b86c3
commit 795e7e4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -325,11 +325,6 @@ parameters:
 			count: 1
 			path: webapp/src/Service/ExternalContestSourceService.php
 
-		-
-			message: "#^Method App\\\\Service\\\\ScoreboardService\\:\\:getScoreboardTwigData\\(\\) return type has no value type specified in iterable type array\\.$#"
-			count: 1
-			path: webapp/src/Service/ScoreboardService.php
-
 		-
 			message: "#^Method App\\\\Service\\\\StatisticsService\\:\\:getGroupedProblemsStats\\(\\) return type has no value type specified in iterable type array\\.$#"
 			count: 1

diff --git a/webapp/src/Service/ScoreboardService.php b/webapp/src/Service/ScoreboardService.php
@@ -865,6 +865,12 @@ public function getFilterValues(Contest $contest, bool $jury): array
 
     /**
      * Get the scoreboard Twig data for a given contest.
+     *
+     * @return array{refresh: array{after: int, url: string, ajax: bool}, static: bool, contest: Contest,
+     *               scoreFilter: Filter, scoreboard: Scoreboard, filterValues: array<string, string[]>,
+     *               groupedAffiliations: null|TeamAffiliation[], showFlags: int, showAffiliationLogos: bool,
+     *               showAffiliations: int, showPending: int, showTeamSubmissions: int, scoreInSeconds: bool,
+     *               maxWidth: int, jury?: bool, public?: bool, ajax?: bool}
      */
     public function getScoreboardTwigData(
         ?Request $request,