DLR-AMR · sandro-elsweijer · Mar 5, 2025 · Mar 6, 2025 · Mar 6, 2025 · Mar 6, 2025
diff --git a/.github/workflows/build_cmake_tarball.yml b/.github/workflows/build_cmake_tarball.yml
@@ -75,7 +75,7 @@ jobs:
 #
 #
     - name: build config variables
-      run: export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=$DEBUG_FLAGS -DCMAKE_CXX_FLAGS_DEBUG=$DEBUG_FLAGS -DT8CODE_USE_SYSTEM_SC=OFF -DT8CODE_USE_SYSTEM_P4EST=OFF -DT8CODE_BUILD_PEDANTIC=ON -DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON -DT8CODE_ENABLE_MPI=$MPI -DCMAKE_BUILD_TYPE=$BUILD_TYPE"
+      run: export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=$DEBUG_FLAGS -DCMAKE_CXX_FLAGS_DEBUG=$DEBUG_FLAGS -DT8CODE_USE_SYSTEM_SC=OFF -DT8CODE_USE_SYSTEM_P4EST=OFF -DT8CODE_BUILD_WPEDANTIC=ON -DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON -DT8CODE_ENABLE_MPI=$MPI -DCMAKE_BUILD_TYPE=$BUILD_TYPE"
         && echo CONFIG_OPTIONS="$CONFIG_OPTIONS" >> $GITHUB_ENV
     - name: cmake
       run: mkdir build && cd build && cmake ../ $CONFIG_OPTIONS
@@ -123,7 +123,7 @@ jobs:
       run: export TEST_LEVEL_FLAG="-DT8CODE_TEST_LEVEL=${{ inputs.TEST_LEVEL }}"
            && echo TEST_LEVEL_FLAG="$TEST_LEVEL_FLAG" >> $GITHUB_ENV
     - name: build config variables
-      run: export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=${DEBUG_CONFIG} -DCMAKE_CXX_FLAGS_DEBUG=${DEBUG_CONFIG} -DT8CODE_USE_SYSTEM_SC=OFF -DT8CODE_USE_SYSTEM_P4EST=OFF -DT8CODE_BUILD_PEDANTIC=ON -DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON  -DT8CODE_ENABLE_MPI=$MPI -DCMAKE_BUILD_TYPE=$BUILD_TYPE"
+      run: export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=${DEBUG_CONFIG} -DCMAKE_CXX_FLAGS_DEBUG=${DEBUG_CONFIG} -DT8CODE_USE_SYSTEM_SC=OFF -DT8CODE_USE_SYSTEM_P4EST=OFF -DT8CODE_BUILD_WPEDANTIC=ON -DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON  -DT8CODE_ENABLE_MPI=$MPI -DCMAKE_BUILD_TYPE=$BUILD_TYPE"
         && echo CONFIG_OPTIONS="$CONFIG_OPTIONS" >> $GITHUB_ENV
     - name: Check vars
       run: echo "[$CONFIG_DEBUG]"

diff --git a/.github/workflows/tests_cmake_t8code.yml b/.github/workflows/tests_cmake_t8code.yml
@@ -84,7 +84,7 @@ jobs:
       run: export TEST_LEVEL_FLAG="-DT8CODE_TEST_LEVEL=${{ inputs.TEST_LEVEL }}"
            && echo TEST_LEVEL_FLAG="$TEST_LEVEL_FLAG" >> $GITHUB_ENV
     - name: build config variables
-      run: export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=${DEBUG_CONFIG} -DCMAKE_CXX_FLAGS_DEBUG=${DEBUG_CONFIG} -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON -DT8CODE_BUILD_PEDANTIC=ON -DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON -DT8CODE_ENABLE_MPI=$MPI -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DSC_DIR=$SC_PATH/install/cmake -DP4EST_DIR=$P4EST_PATH/install/cmake"
+      run: export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=${DEBUG_CONFIG} -DCMAKE_CXX_FLAGS_DEBUG=${DEBUG_CONFIG} -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON -DT8CODE_BUILD_WPEDANTIC=ON -DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON -DT8CODE_ENABLE_MPI=$MPI -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DSC_DIR=$SC_PATH/install/cmake -DP4EST_DIR=$P4EST_PATH/install/cmake"
         && echo CONFIG_OPTIONS="$CONFIG_OPTIONS" >> $GITHUB_ENV
     # cmake and test
     - name: Printing MPI compiler info

diff --git a/.github/workflows/tests_cmake_t8code_api.yml b/.github/workflows/tests_cmake_t8code_api.yml
@@ -85,7 +85,7 @@ jobs:
       run: export TEST_LEVEL_FLAG="-DT8CODE_TEST_LEVEL=${{ inputs.TEST_LEVEL }}"
            && echo TEST_LEVEL_FLAG="$TEST_LEVEL_FLAG" >> $GITHUB_ENV
     - name: build config variables
-      run: export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=${DEBUG_CONFIG} -DCMAKE_CXX_FLAGS_DEBUG=${DEBUG_CONFIG} -DT8CODE_BUILD_FORTRAN_INTERFACE=ON -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON -DT8CODE_BUILD_PEDANTIC=ON -DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON -DT8CODE_ENABLE_MPI=$MPI -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DSC_DIR=$SC_PATH/install/cmake -DP4EST_DIR=$P4EST_PATH/install/cmake"
+      run: export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=${DEBUG_CONFIG} -DCMAKE_CXX_FLAGS_DEBUG=${DEBUG_CONFIG} -DT8CODE_BUILD_FORTRAN_INTERFACE=ON -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON -DT8CODE_BUILD_WPEDANTIC=ON -DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON -DT8CODE_ENABLE_MPI=$MPI -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DSC_DIR=$SC_PATH/install/cmake -DP4EST_DIR=$P4EST_PATH/install/cmake"
            && echo CONFIG_OPTIONS="$CONFIG_OPTIONS" >> $GITHUB_ENV
     # cmake and test with fortran
     - name: check fortran

diff --git a/.github/workflows/tests_cmake_t8code_linkage.yml b/.github/workflows/tests_cmake_t8code_linkage.yml
@@ -85,7 +85,7 @@ jobs:
       run: export TEST_LEVEL_FLAG="-DT8CODE_TEST_LEVEL=${{ inputs.TEST_LEVEL }}"
            && echo TEST_LEVEL_FLAG="$TEST_LEVEL_FLAG" >> $GITHUB_ENV
     - name: build config variables
-      run: export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=${DEBUG_CONFIG} -DCMAKE_CXX_FLAGS_DEBUG=${DEBUG_CONFIG} -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON -DT8CODE_BUILD_PEDANTIC=ON -DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON -DT8CODE_ENABLE_MPI=$MPI -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DSC_DIR=$SC_PATH/install/cmake -DP4EST_DIR=$P4EST_PATH/install/cmake"
+      run: export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=${DEBUG_CONFIG} -DCMAKE_CXX_FLAGS_DEBUG=${DEBUG_CONFIG} -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON -DT8CODE_BUILD_WPEDANTIC=ON -DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON -DT8CODE_ENABLE_MPI=$MPI -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DSC_DIR=$SC_PATH/install/cmake -DP4EST_DIR=$P4EST_PATH/install/cmake"
            && echo CONFIG_OPTIONS="$CONFIG_OPTIONS" >> $GITHUB_ENV
     # cmake and test with netcdf
     - name: check NetCDF

diff --git a/.github/workflows/tests_cmake_t8code_w_shipped_submodules.yml b/.github/workflows/tests_cmake_t8code_w_shipped_submodules.yml
@@ -81,7 +81,7 @@ jobs:
       run: export TEST_LEVEL_FLAG="-DT8CODE_TEST_LEVEL=${{ inputs.TEST_LEVEL }}"
            && echo TEST_LEVEL_FLAG="$TEST_LEVEL_FLAG" >> $GITHUB_ENV
     - name: build config variables
-      run: export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=${DEBUG_CONFIG} -DCMAKE_CXX_FLAGS_DEBUG=${DEBUG_CONFIG} -DT8CODE_BUILD_PEDANTIC=ON -DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON -DT8CODE_ENABLE_MPI=$MPI -DCMAKE_BUILD_TYPE=$BUILD_TYPE"
+      run: export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=${DEBUG_CONFIG} -DCMAKE_CXX_FLAGS_DEBUG=${DEBUG_CONFIG} -DT8CODE_BUILD_WPEDANTIC=ON -DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON -DT8CODE_ENABLE_MPI=$MPI -DCMAKE_BUILD_TYPE=$BUILD_TYPE"
         && echo CONFIG_OPTIONS="$CONFIG_OPTIONS" >> $GITHUB_ENV
     # cmake and test
     - name: Printing MPI compiler info

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -13,7 +13,7 @@ include( CTest )
 include( CMakeDependentOption )
 
 option( T8CODE_BUILD_AS_SHARED_LIBRARY "Whether t8code should be built as a shared or a static library" ON )
-option( T8CODE_BUILD_PEDANTIC "Compile t8code with `-pedantic` as done in the Github CI." OFF )
+option( T8CODE_BUILD_WPEDANTIC "Compile t8code with `-Wpedantic` as done in the Github CI." OFF )
 option( T8CODE_BUILD_WALL "Compile t8code with `-Wall` as done in the Github CI." OFF )
 option( T8CODE_BUILD_WERROR "Compile t8code with `-Werror` as done in the Github CI." OFF )
 option( T8CODE_BUILD_EXTRA_WARNINGS "Compile t8code with extra warnings as done in the Github CI." OFF )
@@ -147,6 +147,91 @@ else()
     add_subdirectory( ${CMAKE_CURRENT_LIST_DIR}/p4est )
 endif()
 
+function(t8_add_cmake_properties target)
+
+    if( CMAKE_BUILD_TYPE STREQUAL "Release" )
+        set (T8_CXXFLAGS "${CMAKE_CXX_FLAGS} ${CMAKE_CXX_FLAGS_RELEASE}")
+        set (T8_CFLAGS "${CMAKE_C_FLAGS} ${CMAKE_C_FLAGS_RELEASE}")
+    endif()
+
+    if( CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo" )
+        set (T8_CXXFLAGS "${CMAKE_CXX_FLAGS} ${CMAKE_CXX_FLAGS_RELWITHDEBINFO}")
+        set (T8_CFLAGS "${CMAKE_C_FLAGS} ${CMAKE_C_FLAGS_RELWITHDEBINFO}")
+    endif()
+
+    if( CMAKE_BUILD_TYPE STREQUAL "Debug" )
+        set (T8_CXXFLAGS "${CMAKE_CXX_FLAGS} ${CMAKE_CXX_FLAGS_DEBUG}")
+        set (T8_CFLAGS "${CMAKE_C_FLAGS} ${CMAKE_C_FLAGS_DEBUG}")
+        target_compile_definitions( ${target} PUBLIC T8_ENABLE_DEBUG )
+    endif()
+
+    if( T8CODE_EXPORT_COMPILE_COMMANDS )
+        set_target_properties( ${target} PROPERTIES EXPORT_COMPILE_COMMANDS ON )
+    endif( T8CODE_EXPORT_COMPILE_COMMANDS )
+
+    target_link_libraries( ${target} PUBLIC P4EST::P4EST SC::SC )
+
+    if ( T8CODE_ENABLE_MPI )
+        target_compile_definitions( ${target} PUBLIC T8_ENABLE_MPI )
+        target_compile_definitions( ${target} PUBLIC T8_ENABLE_MPIIO )
+        target_link_libraries( ${target} PUBLIC MPI::MPI_C )
+    endif()
+
+    if( T8CODE_ENABLE_VTK )
+        target_compile_definitions( ${target} PUBLIC T8_VTK_VERSION_USED="${VTK_MAJOR_VERSION}.${VTK_MINOR_VERSION}" )
+        target_compile_definitions( ${target} PUBLIC T8_WITH_VTK=1 )
+        target_include_directories( ${target} PUBLIC ${VTK_INCLUDE_DIR} )
+        target_link_libraries( ${target} PUBLIC ${VTK_LIBRARIES} )
+    endif()
+
+    if( T8CODE_ENABLE_OCC )
+        target_compile_definitions( ${target} PUBLIC T8_WITH_OCC=1 )
+        target_include_directories( ${target} SYSTEM PUBLIC ${OpenCASCADE_INCLUDE_DIR} )
+        target_link_libraries( ${target} PUBLIC ${OpenCASCADE_LIBRARIES} )
+    endif()
+
+    if( T8CODE_ENABLE_NETCDF )
+        target_link_libraries( ${target} PUBLIC netCDF::netcdf )
+        target_compile_definitions(${target} PUBLIC
+            T8_WITH_NETCDF
+            $<$<AND:$<BOOL:${NETCDF_HAVE_NETCDF_PAR}>,$<BOOL:${T8CODE_ENABLE_MPI}>>:T8_WITH_NETCDF_PAR>
+        )
+    endif()
+
+    if( T8CODE_BUILD_WPEDANTIC )
+      target_compile_options( ${target} PUBLIC -Wpedantic )
+      set (T8_CXXFLAGS "${T8_CXXFLAGS} -Wpedantic")
+      set (T8_CFLAGS "${T8_CFLAGS} -Wpedantic")
+    endif()
+
+    if( T8CODE_BUILD_WALL)
+      target_compile_options( ${target} PUBLIC -Wall )
+      set (T8_CXXFLAGS "${T8_CXXFLAGS} -Wall")
+      set (T8_CFLAGS "${T8_CFLAGS} -Wall")
+    endif()
+
+    if( T8CODE_BUILD_WERROR )
+      target_compile_options( ${target} PUBLIC -Werror )
+      set (T8_CXXFLAGS "${T8_CXXFLAGS} -Werror")
+      set (T8_CFLAGS "${T8_CFLAGS} -Werror")
+    endif()
+
+    target_compile_definitions( ${target} PUBLIC T8_CMAKE_BUILD )
+    target_compile_definitions( ${target} PUBLIC T8_CC="${CMAKE_C_COMPILER}" )
+    target_compile_definitions( ${target} PUBLIC T8_CFLAGS="${T8_CFLAGS}" )
+    target_compile_definitions( ${target} PUBLIC T8_CXX="${CMAKE_CXX_COMPILER}" )
+    target_compile_definitions( ${target} PUBLIC T8_CXXFLAGS="${T8_CXXFLAGS}" )
+    target_compile_definitions( ${target} PUBLIC T8_LDFLAGS="${CMAKE_SHARED_LINKER_FLAGS}" )
+
+    target_compile_definitions( ${target} PUBLIC T8_PACKAGE_STRING="t8 ${T8CODE_VERSION}" )
+    target_compile_definitions( ${target} PUBLIC T8_VERSION="${T8CODE_VERSION}" )
+    target_compile_definitions( ${target} PUBLIC T8_VERSION_MAJOR=${T8CODE_VERSION_MAJOR} )
+    target_compile_definitions( ${target} PUBLIC T8_VERSION_MINOR=${T8CODE_VERSION_MINOR} )
+    target_compile_definitions( ${target} PUBLIC T8_VERSION_PATCH=${T8CODE_VERSION_PATCH} )
+    target_compile_definitions( ${target} PUBLIC T8_VERSION_POINT=${T8CODE_VERSION_POINT} )
+
+endfunction(t8_add_cmake_properties)
+
 add_subdirectory( ${CMAKE_CURRENT_LIST_DIR}/src )
 
 if ( T8CODE_BUILD_TESTS )

diff --git a/benchmarks/CMakeLists.txt b/benchmarks/CMakeLists.txt
@@ -14,17 +14,14 @@ function( add_t8_benchmark )
     add_executable( ${ADD_T8_BENCHMARK_NAME} ${ADD_T8_BENCHMARK_SOURCES} )
     target_include_directories( ${ADD_T8_BENCHMARK_NAME} PRIVATE ${PROJECT_SOURCE_DIR} )
     target_link_libraries( ${ADD_T8_BENCHMARK_NAME} PRIVATE T8 SC::SC )
+    t8_add_cmake_properties( ${ADD_T8_BENCHMARK_NAME} )
 
     set_target_properties(${ADD_T8_BENCHMARK_NAME} PROPERTIES
         RUNTIME_OUTPUT_DIRECTORY "${BENCHMARK_BUILD_DIR}"
         LIBRARY_OUTPUT_DIRECTORY "${BENCHMARK_BUILD_DIR}"
         ARCHIVE_OUTPUT_DIRECTORY "${BENCHMARK_BUILD_DIR}"
     )
 
-    if( T8CODE_EXPORT_COMPILE_COMMANDS )
-        set_target_properties( ${ADD_T8_BENCHMARK_NAME} PROPERTIES EXPORT_COMPILE_COMMANDS ON )
-    endif( T8CODE_EXPORT_COMPILE_COMMANDS )
-
     install( TARGETS ${ADD_T8_BENCHMARK_NAME} DESTINATION bin )
 endfunction()
 

diff --git a/example/CMakeLists.txt b/example/CMakeLists.txt
@@ -25,17 +25,14 @@ function( add_t8_example )
     add_executable( ${ADD_T8_EXAMPLE_NAME} ${ADD_T8_EXAMPLE_SOURCES} )
     target_link_libraries( ${ADD_T8_EXAMPLE_NAME} PRIVATE T8 t8example SC::SC )
     target_include_directories( ${ADD_T8_EXAMPLE_NAME} PRIVATE ${CMAKE_CURRENT_LIST_DIR}/.. )
+    t8_add_cmake_properties( ${ADD_T8_EXAMPLE_NAME} )
 
     set_target_properties(${ADD_T8_EXAMPLE_NAME} PROPERTIES
         RUNTIME_OUTPUT_DIRECTORY "${EXAMPLE_BUILD_DIR}"
         LIBRARY_OUTPUT_DIRECTORY "${EXAMPLE_BUILD_DIR}"
         ARCHIVE_OUTPUT_DIRECTORY "${EXAMPLE_BUILD_DIR}"
     )
 
-    if( T8CODE_EXPORT_COMPILE_COMMANDS )
-        set_target_properties( ${ADD_T8_EXAMPLE_NAME} PROPERTIES EXPORT_COMPILE_COMMANDS ON )
-    endif( T8CODE_EXPORT_COMPILE_COMMANDS )
-
     install( TARGETS ${ADD_T8_EXAMPLE_NAME} DESTINATION bin )
 endfunction()