-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify target compile definitions #1458
base: main
Are you sure you want to change the base?
Conversation
1033c12
to
122cc9c
Compare
The compiler option for the others is called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR unifies the compile definitions across targets by introducing a function to add all relevant compile definitions and renaming the pedantic build option for consistency.
- Updated CI workflow YAMLs to replace T8CODE_BUILD_PEDANTIC with T8CODE_BUILD_WPEDANTIC.
- Ensured consistent compile configuration flags across different build jobs.
Reviewed Changes
File | Description |
---|---|
.github/workflows/build_cmake_tarball.yml | Replaced T8CODE_BUILD_PEDANTIC with T8CODE_BUILD_WPEDANTIC. |
.github/workflows/tests_cmake_t8code_api.yml | Replaced T8CODE_BUILD_PEDANTIC with T8CODE_BUILD_WPEDANTIC. |
.github/workflows/tests_cmake_t8code.yml | Replaced T8CODE_BUILD_PEDANTIC with T8CODE_BUILD_WPEDANTIC. |
.github/workflows/tests_cmake_t8code_linkage.yml | Replaced T8CODE_BUILD_PEDANTIC with T8CODE_BUILD_WPEDANTIC. |
.github/workflows/tests_cmake_t8code_w_shipped_submodules.yml | Replaced T8CODE_BUILD_PEDANTIC with T8CODE_BUILD_WPEDANTIC. |
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Describe your changes here:
The cmake system ad its own definitions for each target (t8code itself and each benchmark, test, tutorial and example).
This PR introduces a function which adds all relevant compile definitions to a target. This way everything in t8code is compiled the same way.
Furthermore, this PR renames the
T8CODE_BUILD_PEDANTIC
option intoT8CODE_BUILD_WPEDANTIC
so that it is in line withT8CODE_BUILD_WALL
T8CODE_BUILD_WERROR
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.sh
to check the indentation of these files.License
doc/
(or already has one)Tag Label