Coordinate fixes

.gitignore

@@ -227,3 +227,4 @@ figure_test_images*
 
 # Release script
 .github_cache
+requirements-min.txt

changelog/305.breaking.rst

@@ -0,0 +1 @@
+We now require gwcs 0.19+ and therefore astropy 5.3+

changelog/305.bugfix.1.rst

@@ -0,0 +1 @@
+Fix the oversight that when generating a model for a celestial WCS the scale model was put before the affine transform in the pipeline. This means that the units for the affine transform matrix provided to ``VaryingCelestialTransform`` and ``generate_celestial_transform`` should be pixels not degrees.

changelog/305.bugfix.rst

@@ -0,0 +1 @@
+Fix missing references to parent transform schemas in ``Ravel`` and ``VaryingCelestialTransform`` ASDF schemas.

changelog/305.feature.rst

@@ -0,0 +1 @@
+Add a new ``AsymmetricMapping`` model to allow a different mapping in the forward and reverse directions.

changelog/305.internal.rst

@@ -0,0 +1 @@
+Remove all ``*Slit`` varying celestial transform models and replace them with a compound model combining a ``VaryingCelestialTransform`` and an ``AsymmetricMapping``.

dkist/conftest.py

@@ -179,7 +179,7 @@ def generate_lookup_table(lookup_table, interpolation='linear', points_unit=u.pi
 @pytest.fixture
 def identity_gwcs_5d_stokes(identity_gwcs_4d):
     stokes_frame = cf.StokesFrame(axes_order=(4,))
-    stokes_model = generate_lookup_table([0, 1, 2, 3] * u.one, interpolation='nearest')
+    stokes_model = generate_lookup_table([1, 2, 3, 4] * u.one, interpolation='nearest')
     transform = identity_gwcs_4d.forward_transform
     frame = cf.CompositeFrame(identity_gwcs_4d.output_frame.frames + [stokes_frame])
 

dkist/data/test/EIT/eit_test_dataset.asdf

@@ -4,41 +4,41 @@
 %TAG ! tag:stsci.edu:asdf/
 --- !core/asdf-1.1.0
 asdf_library: !core/software-1.0.0 {author: The ASDF Developers, homepage: 'http://github.com/asdf-format/asdf',
-  name: asdf, version: 2.14.3}
+  name: asdf, version: 2.15.2}
 history:
   extensions:
   - !core/extension_metadata-1.0.0
     extension_class: asdf.extension.BuiltinExtension
-    software: !core/software-1.0.0 {name: asdf, version: 2.14.3}
+    software: !core/software-1.0.0 {name: asdf, version: 2.15.2}
   - !core/extension_metadata-1.0.0
     extension_class: asdf.extension._manifest.ManifestExtension
-    extension_uri: asdf://astropy.org/astropy/extensions/astropy-1.0.0
-    software: !core/software-1.0.0 {name: asdf-astropy, version: 0.3.0}
+    extension_uri: asdf://asdf-format.org/astronomy/gwcs/extensions/gwcs-1.1.0
+    software: !core/software-1.0.0 {name: gwcs, version: 0.19.1.dev19+g50e2340}
   - !core/extension_metadata-1.0.0
     extension_class: asdf.extension._manifest.ManifestExtension
-    extension_uri: asdf://asdf-format.org/astronomy/gwcs/extensions/gwcs-1.0.0
-    software: !core/software-1.0.0 {name: gwcs, version: 0.18.3}
+    extension_uri: asdf://astropy.org/astropy/extensions/astropy-1.0.0
+    software: !core/software-1.0.0 {name: asdf-astropy, version: 0.4.0}
   - !core/extension_metadata-1.0.0
-    extension_class: asdf.extension._manifest.ManifestExtension
-    extension_uri: asdf://dkist.nso.edu/dkist/extensions/dkist-1.0.0
-    software: !core/software-1.0.0 {name: dkist, version: 1.0.0b10.dev10+g5493c6f}
+    extension_class: asdf_astropy._manifest.CompoundManifestExtension
+    extension_uri: asdf://asdf-format.org/core/extensions/core-1.5.0
+    software: !core/software-1.0.0 {name: asdf-astropy, version: 0.4.0}
   - !core/extension_metadata-1.0.0
     extension_class: asdf.extension._manifest.ManifestExtension
-    extension_uri: asdf://asdf-format.org/core/extensions/core-1.5.0
-    software: !core/software-1.0.0 {name: asdf-astropy, version: 0.3.0}
+    extension_uri: asdf://dkist.nso.edu/dkist/extensions/dkist-1.0.0
+    software: !core/software-1.0.0 {name: dkist, version: 1.0.2.dev19+g1224aa5.d20231020}
   - !core/extension_metadata-1.0.0
     extension_class: asdf.extension._manifest.ManifestExtension
     extension_uri: asdf://asdf-format.org/transform/extensions/transform-1.5.0
-    software: !core/software-1.0.0 {name: asdf-astropy, version: 0.3.0}
+    software: !core/software-1.0.0 {name: asdf-astropy, version: 0.4.0}
   - !core/extension_metadata-1.0.0
     extension_class: asdf.extension._manifest.ManifestExtension
     extension_uri: asdf://sunpy.org/extensions/sunpy-1.0.0
-    software: !core/software-1.0.0 {name: sunpy, version: 4.1.1}
+    software: !core/software-1.0.0 {name: sunpy, version: 5.0.1}
   - !core/extension_metadata-1.0.0
     extension_class: asdf.extension._manifest.ManifestExtension
     extension_uri: asdf://asdf-format.org/astronomy/coordinates/extensions/coordinates-1.0.0
-    software: !core/software-1.0.0 {name: asdf-astropy, version: 0.3.0}
-dataset: !<asdf://dkist.nso.edu/tags/dataset-1.1.0>
+    software: !core/software-1.0.0 {name: asdf-astropy, version: 0.4.0}
+dataset: !<asdf://dkist.nso.edu/tags/dataset-1.2.0>
   data: !<asdf://dkist.nso.edu/tags/file_manager-1.0.0>
     datatype: float64
     fileuris: [efz20040301.000010_s.fits, efz20040301.020010_s.fits, efz20040301.030011_s.fits,
@@ -388,10 +388,10 @@ dataset: !<asdf://dkist.nso.edu/tags/dataset-1.1.0>
       qtable: false
     inventory: {}
   unit: !unit/unit-1.0.0 count.pixel**-1
-  wcs: !<tag:stsci.edu:gwcs/wcs-1.0.0>
+  wcs: !<tag:stsci.edu:gwcs/wcs-1.1.0>
     name: ''
     steps:
-    - !<tag:stsci.edu:gwcs/step-1.0.0>
+    - !<tag:stsci.edu:gwcs/step-1.1.0>
       frame: !<tag:stsci.edu:gwcs/frame-1.0.0>
         axes_names: [x, y, z]
         axes_order: [0, 1, 2]
@@ -501,7 +501,7 @@ dataset: !<asdf://dkist.nso.edu/tags/dataset-1.1.0>
               shape: [11]
         inputs: [x0, x1, x]
         outputs: [alpha_C, delta_C, y]
-    - !<tag:stsci.edu:gwcs/step-1.0.0>
+    - !<tag:stsci.edu:gwcs/step-1.1.0>
       frame: !<tag:stsci.edu:gwcs/composite_frame-1.0.0>
         frames:
         - !<tag:stsci.edu:gwcs/celestial_frame-1.0.0>
@@ -610,55 +610,55 @@ N
 �BLK0   ��hm�B������,�Z�?��?�BLK0J�6�K��y�u.#H��BLK0XXX'\b�-���V�VŻ���n�  �@���q�@W9�� �@+�
��@��Q���@*�� �@�G�z��@V
��@w��V�@���
�@�BLK0XXX��!�Z%��,%����?@@@@@@ @"@$@#ASDF BLOCK INDEX
 %YAML 1.1
 ---
-- 18440
-- 18505
-- 18647
-- 18789
-- 18931
-- 19073
-- 19567
-- 19973
-- 21039
-- 21709
-- 22071
-- 22301
-- 22487
-- 22893
-- 23563
-- 23705
-- 23979
-- 25089
-- 25715
-- 26473
-- 26615
-- 26757
-- 27163
-- 28009
-- 28151
-- 28293
-- 28655
-- 29017
-- 29159
-- 29301
-- 29443
-- 29585
-- 29727
-- 29869
-- 30011
-- 30153
-- 30295
-- 30437
-- 30579
-- 30721
-- 30863
-- 31005
-- 31147
-- 31289
-- 31431
-- 31573
-- 31715
-- 31857
-- 31943
-- 32013
-- 32155
+- 18468
+- 18533
+- 18675
+- 18817
+- 18959
+- 19101
+- 19595
+- 20001
+- 21067
+- 21737
+- 22099
+- 22329
+- 22515
+- 22921
+- 23591
+- 23733
+- 24007
+- 25117
+- 25743
+- 26501
+- 26643
+- 26785
+- 27191
+- 28037
+- 28179
+- 28321
+- 28683
+- 29045
+- 29187
+- 29329
+- 29471
+- 29613
+- 29755
+- 29897
+- 30039
+- 30181
+- 30323
+- 30465
+- 30607
+- 30749
+- 30891
+- 31033
+- 31175
+- 31317
+- 31459
+- 31601
+- 31743
+- 31885
+- 31971
+- 32041
+- 32183
 ...