-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coordinate fixes #305
Coordinate fixes #305
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
==========================================
- Coverage 98.28% 97.68% -0.61%
==========================================
Files 40 32 -8
Lines 2454 1854 -600
==========================================
- Hits 2412 1811 -601
- Misses 42 43 +1
☔ View full report in Codecov by Sentry. |
983580d
to
378dda0
Compare
unit and ordering
This let's us test some other bits on 0.19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 I'm still playing a bit with getting the updated asdfs through my crop tests, but they've taken everything I've been able to through at them so far and the remaining issues are at my end so I don't see why they should block this being merged.
This is the dkist part of a multi-project improvement to the coordinate info saved into ASDF.
See Also: