Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate fixes #305

Merged
merged 38 commits into from
Oct 27, 2023
Merged

Coordinate fixes #305

merged 38 commits into from
Oct 27, 2023

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Oct 16, 2023

@Cadair Cadair changed the title Visp wcs [WIP] Coordinate fixes Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4f2172) 98.28% compared to head (6a45926) 97.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
- Coverage   98.28%   97.68%   -0.61%     
==========================================
  Files          40       32       -8     
  Lines        2454     1854     -600     
==========================================
- Hits         2412     1811     -601     
- Misses         42       43       +1     
Files Coverage Δ
dkist/dataset/loader.py 100.00% <ø> (ø)
dkist/io/asdf/converters/__init__.py 100.00% <100.00%> (ø)
dkist/io/asdf/converters/dataset.py 94.87% <100.00%> (+1.32%) ⬆️
dkist/io/asdf/converters/models.py 98.46% <100.00%> (+0.50%) ⬆️
dkist/io/asdf/entry_points.py 100.00% <100.00%> (ø)
dkist/wcs/models.py 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cadair Cadair force-pushed the visp_wcs branch 6 times, most recently from 983580d to 378dda0 Compare October 20, 2023 13:48
@Cadair Cadair marked this pull request as ready for review October 20, 2023 14:21
@Cadair Cadair changed the title [WIP] Coordinate fixes Coordinate fixes Oct 20, 2023
Copy link
Contributor

@SolarDrew SolarDrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I'm still playing a bit with getting the updated asdfs through my crop tests, but they've taken everything I've been able to through at them so far and the remaining issues are at my end so I don't see why they should block this being merged.

changelog/305.bugfix.1.rst Outdated Show resolved Hide resolved
dkist/io/asdf/converters/dataset.py Show resolved Hide resolved
dkist/utils/_model_to_graphviz.py Outdated Show resolved Hide resolved
dkist/utils/_model_to_graphviz.py Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@Cadair Cadair merged commit 9c4f1ba into DKISTDC:main Oct 27, 2023
12 of 13 checks passed
@Cadair Cadair deleted the visp_wcs branch October 27, 2023 10:44
@Cadair Cadair restored the visp_wcs branch October 27, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants