Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new slider widget to devel/hello-world #1363

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Added new slider widget to devel/hello-world #1363

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1b79147
Create helloSlider.lua
realSquidCoder Jan 1, 2025
9d68aca
Update helloSlider.lua to try and fix precommit EOF errors
realSquidCoder Jan 1, 2025
bbac6c4
Merge branch 'master' into squid-slider-widget
realSquidCoder Jan 16, 2025
81e5179
Move code to new files
realSquidCoder Jan 16, 2025
735f5d5
Clean up code
realSquidCoder Jan 20, 2025
9055dc8
Clean up the code and add a divider
realSquidCoder Jan 20, 2025
ca91203
Merge branch 'DFHack:master' into squid-slider-widget
realSquidCoder Jan 26, 2025
45c1997
Update hello-world.lua
realSquidCoder Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 39 additions & 3 deletions devel/hello-world.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,27 @@ local HIGHLIGHT_PEN = dfhack.pen.parse{

HelloWorldWindow = defclass(HelloWorldWindow, widgets.Window)
HelloWorldWindow.ATTRS{
frame={w=20, h=14},
frame={w=25, h=25},
frame_title='Hello World',
autoarrange_subviews=true,
autoarrange_gap=1,
autoarrange_gap=2,
resizable=true,
resize_min={w=25, h=25},
}

function HelloWorldWindow:init()
local LEVEL_OPTIONS = {
{label='Low', value=1},
{label='Medium', value=2},
{label='High', value=3},
{label='Pro', value=4},
{label='Insane', value=5},
}

self:addviews{
widgets.Label{text={{text='Hello, world!', pen=COLOR_LIGHTGREEN}}},
widgets.HotkeyLabel{
frame={l=0, t=0},
frame={l=0},
label='Click me',
key='CUSTOM_CTRL_A',
on_activate=self:callback('toggleHighlight'),
Expand All @@ -32,6 +42,32 @@ function HelloWorldWindow:init()
frame={w=10, h=5},
frame_style=gui.INTERIOR_FRAME,
},
widgets.Divider{
realSquidCoder marked this conversation as resolved.
Show resolved Hide resolved
frame={h=1},
frame_style_l=false,
frame_style_r=false,
},
widgets.CycleHotkeyLabel{
view_id='level',
frame={l=0, w=20},
label='Level:',
label_below=false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove the label_below attribute

key_back='CUSTOM_SHIFT_C',
key='CUSTOM_SHIFT_V',
options=LEVEL_OPTIONS,
initial_option=LEVEL_OPTIONS[1].value,
on_change=function(val)
self.callback{Slider.on_change(val)}
end,
Comment on lines +59 to +61
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this on_change handler isn't necessary. it also appears to have a syntax error

},
widgets.Slider{
frame={l=1},
num_stops=#LEVEL_OPTIONS,
get_idx_fn=function()
return self.subviews.level:getOptionValue()
end,
on_change=function(idx) self.subviews.level:setOption(idx) end,
},
}
end

Expand Down
Loading