Added new slider widget to devel/hello-world
#1363
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created helloSlider.lua (a prototype for a new single-slider widget)
myk002
reviewed
Jan 1, 2025
Move Slider example into the hello world move the Slider widget away to its proper place (DFHack Repo).
realSquidCoder
changed the title
devel/hello-world
myk002
reviewed
Jan 20, 2025
|
also needs a changelog entry |
myk002
reviewed
Jan 28, 2025
Comment on lines
+59
to
+61
| on_change=function(val) | ||
| self.callback{Slider.on_change(val)} | ||
| end, |
There was a problem hiding this comment.
this on_change handler isn't necessary. it also appears to have a syntax error
| view_id='level', | ||
| frame={l=0, w=20}, | ||
| label='Level:', | ||
| label_below=false, |
There was a problem hiding this comment.
you can remove the label_below attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created
devel/helloSlider.lua(a prototype for a new single-slider widget)