[ER-758] main hero layout #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add colour to module progress - Add pages to section heading
… ER-758-main-hero-layout
|
This pull request is split into 8 parts for easier review. Changed files are located in these folders:
|
Closed
jack-coggin
had a problem deploying
to
development
GitHub Actions
Failure
jack-coggin
had a problem deploying
to
content
GitHub Actions
Failure
jack-coggin
had a problem deploying
to
development
GitHub Actions
Failure
jack-coggin
had a problem deploying
to
development
GitHub Actions
Failure
jack-coggin
had a problem deploying
to
development
GitHub Actions
Failure
jack-coggin
had a problem deploying
to
development
GitHub Actions
Failure
jack-coggin
had a problem deploying
to
content
GitHub Actions
Failure
jack-coggin
reviewed
Oct 3, 2023
jack-coggin
temporarily deployed
to
development
GitHub Actions
Inactive
github-actions
bot
removed
documentation
|
Going to resolve #708 in here |
- Remove unused styling - Tidy up - Tweaks to meet latest ACs
peterdavidhamilton
had a problem deploying
to
test
GitHub Actions
Failure
peterdavidhamilton
temporarily deployed
to
content
GitHub Actions
Inactive
peterdavidhamilton
temporarily deployed
to
development
GitHub Actions
Inactive
peterdavidhamilton
had a problem deploying
to
test
GitHub Actions
Failure
peterdavidhamilton
temporarily deployed
to
content
GitHub Actions
Inactive
peterdavidhamilton
temporarily deployed
to
development
GitHub Actions
Inactive
peterdavidhamilton
had a problem deploying
to
test
GitHub Actions
Failure
peterdavidhamilton
temporarily deployed
to
development
GitHub Actions
Inactive
peterdavidhamilton
had a problem deploying
to
production
GitHub Actions
Failure
peterdavidhamilton
added a commit
that referenced
this pull request
Oct 9, 2023
* Add dfe header * Adjustments for header in preparation for adding hero section * Main hero layout proof of concept * Module overview updates - Add colour to module progress - Add pages to section heading * styling adjustments for dfe-frontend integration * update yarn.lock * revert changes to dfe frontend version * remove path shown in header * revert dockerfile changes * upgrade dfe frontend * change dev cms env to staging * revert cms env change * decrease disk quota * - Positional section progress bar - Additional section for certificate in overview - Page styling and pagination changes * Revert "styling adjustments for dfe-frontend integration" This reverts commit f954fd0. * Revert "decrease disk quota" This reverts commit 23146fe. * Revert "Revert "styling adjustments for dfe-frontend integration"" This reverts commit 07f794b. * fix module content view and training text page * reduce disk quota * Change (now redundant following move to Azure) review app envs * Improve in app debugging for module authors * lint * docs * merge with header * - Fix test suite - Remove unused styling - Tidy up - Tweaks to meet latest ACs * Add missing hero to question response validations --------- Co-authored-by: jack.coggin <[email protected]> Co-authored-by: Peter David Hamilton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rework of #784 with two layouts, rather than a single layout.
From the lucid board the majority of pages will have hero sections, so as we work on future design changes, it might be best to make the hero included layout the default.
Also:
ER-759 Two small changes for module overview
Add number of pages to the section heading; the last section does not show number of pages. Moving the certificate to own section is handled by updates in contentful, therefore no code changes beyond the page numbers exception for the last section.