Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hero section #784

Closed
wants to merge 22 commits into from
Closed

Hero section #784

wants to merge 22 commits into from

Conversation

ebrett
Copy link
Contributor

@ebrett ebrett commented Aug 21, 2023 •
edited
Loading

ER-758 Add hero section to following pages

  • My modules
  • Module over page
  • Pages with progress bar
    • Text page
    • Question page
    • Video page
  • Certificate

@ebrett ebrett added the deployed Review app deployed for testing label Aug 21, 2023
@ebrett ebrett temporarily deployed to content August 21, 2023 12:35 — with GitHub Actions Inactive
@viezly
Copy link

viezly bot commented Aug 21, 2023 •
edited
Loading

This pull request is split into 7 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • /
  • app
  • app/views
  • config
  • spec/lib
  • spec/system
  • terraform-azure

@github-actions
Copy link

github-actions bot commented Aug 21, 2023 •
edited
Loading

https://ey-recovery-pr-784.london.cloudapps.digital

@ebrett ebrett temporarily deployed to content August 21, 2023 14:17 — with GitHub Actions Inactive
@ebrett ebrett temporarily deployed to development August 21, 2023 14:17 — with GitHub Actions Inactive
@github-actions github-actions bot added the frontend Changes to assets detected label Aug 21, 2023
@ebrett ebrett temporarily deployed to content August 21, 2023 14:25 — with GitHub Actions Inactive
@ebrett ebrett temporarily deployed to test August 21, 2023 14:25 — with GitHub Actions Inactive
@ebrett ebrett temporarily deployed to development August 21, 2023 14:25 — with GitHub Actions Inactive
@ebrett ebrett marked this pull request as ready for review August 21, 2023 14:40
@peterdavidhamilton peterdavidhamilton added this to the branding milestone Aug 22, 2023
@ebrett ebrett temporarily deployed to development August 22, 2023 11:09 — with GitHub Actions Inactive
@ebrett ebrett temporarily deployed to content August 22, 2023 11:09 — with GitHub Actions Inactive
@ebrett ebrett temporarily deployed to development August 22, 2023 12:17 — with GitHub Actions Inactive
@ebrett ebrett temporarily deployed to content August 22, 2023 12:17 — with GitHub Actions Inactive
@ebrett ebrett temporarily deployed to test August 22, 2023 12:24 — with GitHub Actions Inactive
@ebrett ebrett temporarily deployed to content August 22, 2023 12:24 — with GitHub Actions Inactive
@ebrett ebrett temporarily deployed to development August 22, 2023 12:24 — with GitHub Actions Inactive
ebrett and others added 22 commits September 7, 2023 12:42
@ebrett
Update DfE Header
3e1e312
@ebrett
Fix spec
be70f86
@ebrett
Remove unused scss
941af9d
@ebrett
Break line in footer should be full width
f2455b9
@ebrett
Revert debug flag
962d8ef
@ebrett
Correct max-width inside notification banner
b38c738
@ebrett
Use existing configuration
65e80ea
@ebrett
Use 44em for max-width
b46bf45
@peterdavidhamilton @ebrett
Avoid increasing disk quota by tidying up after new DfE project code
f0d066b 
dfe-frontend-alpha > backstopjs > playwright
@ebrett
fix width on tables and learning log
bc5eef6
@ebrett
remove hard coded print link image
b38efc9
@ebrett
Add row/column for text page to two-thirds width
3c02bd1 
- my account should be three quarters
@ebrett
remove duplicate style for gem-c-govspeak
28a867f
@ebrett
override typography style for h2 in dfe-frontend-alpha
79806eb
@ebrett
debug off by default
0844994
@ebrett
Hero section
c6ead32
@ebrett
Add certificate page
7569cc8
@ebrett
Add hero section
e114a86 
- Text page
- Question
- Video page
@ebrett
Correct after conflict resolution
4c97267
@ebrett
Inadvertantly added
a2fe576
@ebrett
Omitted if
150f0f4
@ebrett
Use page width for dfe-width-container
f3f3e3a
@ebrett ebrett force-pushed the ER-738-training-site-design branch 3 times, most recently from 5899c84 to 6d41307 Compare September 8, 2023 08:38
@ebrett ebrett mentioned this pull request Sep 11, 2023
Merged
@ebrett ebrett closed this Sep 11, 2023
@ebrett
Copy link
Contributor Author

ebrett commented Sep 11, 2023

see #826

@peterdavidhamilton peterdavidhamilton deleted the ER-758-hero branch October 17, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdavidhamilton peterdavidhamilton peterdavidhamilton left review comments

@jack-coggin jack-coggin Awaiting requested review from jack-coggin

Assignees
No one assigned
Labels
deployed Review app deployed for testing frontend Changes to assets detected
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ebrett @peterdavidhamilton