Temporarily skip pdf tests to unblock merging #9613
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Our tests related to downloading a PDF have started to fail since a chromium update. The last time the test suite passed:
ran
apk add chromium chromium-chromedriver
=>
(1/1) Installing chromium-chromedriver (126.0.6478.182-r0)
It started to fail when this started to happen:
apk add chromium chromium-chromedriver
=>
(1/2) Upgrading chromium (126.0.6478.182-r0 -> 127.0.6533.72-r0)
Alpine does not support older versions of chromium, so we can't pin the working version.
Changes proposed in this pull request
Temporarily skip failing tests. I've created a card for investigating a replacement for Grover (which has caused us problems before). And I've put a note in my diary to check what version of Chromium is being used by Alpine in two weeks time to see if the issue has resolved itself.
Guidance to review
Link to Trello card
Things to check