Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily skip pdf tests to unblock merging #9613

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented Jul 31, 2024

Context

Our tests related to downloading a PDF have started to fail since a chromium update. The last time the test suite passed:

ran apk add chromium chromium-chromedriver
=> (1/1) Installing chromium-chromedriver (126.0.6478.182-r0)

It started to fail when this started to happen:

apk add chromium chromium-chromedriver
=> (1/2) Upgrading chromium (126.0.6478.182-r0 -> 127.0.6533.72-r0)

Alpine does not support older versions of chromium, so we can't pin the working version.

Changes proposed in this pull request

Temporarily skip failing tests. I've created a card for investigating a replacement for Grover (which has caused us problems before). And I've put a note in my diary to check what version of Chromium is being used by Alpine in two weeks time to see if the issue has resolved itself.

Guidance to review

Link to Trello card

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes

@elceebee elceebee changed the title Temporarily pdf tests to unblock merging Temporarily skip pdf tests to unblock merging Jul 31, 2024
@elceebee elceebee marked this pull request as ready for review August 1, 2024 08:43
@elceebee elceebee requested a review from a team August 1, 2024 08:44
@elceebee elceebee merged commit 6e2e05d into main Aug 1, 2024
23 checks passed
@elceebee elceebee deleted the temporarily-skip-tests branch August 1, 2024 08:47
@elceebee elceebee mentioned this pull request Aug 15, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants