Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate test #9696

Merged

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented Aug 15, 2024

Context

See PR for skipping the test and this slack thread for context.

Chromium version has been updated
(1/1) Installing chromium-chromedriver (127.0.6533.99-r0)

Changes proposed in this pull request

This just reinstates a test for downloading PDFs that was temporarily disabled.

Guidance to review

All tests pass now on CI, so

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@elceebee elceebee marked this pull request as ready for review August 15, 2024 07:41
@elceebee elceebee merged commit 0807336 into main Aug 15, 2024
23 checks passed
@elceebee elceebee deleted the reinstate-skipped-test-failing-because-of-chromium-version branch August 15, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants