Add namedtuple, pyspark, ibis, lc to SDK coverage #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrawcz
force-pushed
the
add_nametuple_support_to_sdk
branch
2 times, most recently
from
1e5a616 to
6758624
Compare
This was missed. Adds matrix to run over different python versions. We don’t do 3.12 because ray doesn’t support that yet. Should be fine.
They can be converted to dictionaries easily. So we do that. Otherwise we special case 'secret_key' since that's a legacy way we were telling people to wrap API Keys with. Fixes some unit tests that weren't updated.
These are lazily done - so best we can do is get some schema and maybe a query plan in the case of pyspark.
Because some dependencies might not exist -- because they are lazily loaded. This guards against that.
This covers documents and messages. It is basic, and not mean to really enable deserialization, but we do have the components here to know which is which. Otherwise rather than a special type, using dict for now. Can always change it and coordinate with the UI. This also adds missing tests for the other new SDK additions. Note: we use `_stats` as the prefix for these files to indicate that there could be missing information. If we wanted to properly cache etc, we could do so, but we'd want to do it via another means I think.
skrawcz
force-pushed
the
add_nametuple_support_to_sdk
branch
from
6758624 to
1968b43
Compare
7 tasks
skrawcz
changed the title
To clarify / provide more color to the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an SDK update to capture more data types.
These all push to a dict -- we could create specific UI experiences for them, will do so in the future.
Changes
SDK now can capture:
How I tested this
locally
Notes
Checklist