Skip to content

Commit

Permalink
Adds some extra comments
Browse files Browse the repository at this point in the history
To clarify / provide more color to the documentation.
  • Loading branch information
skrawcz committed May 14, 2024
1 parent b3b33a3 commit 683e657
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion ui/sdk/src/hamilton_sdk/driver.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ def _hash_module(
)

def safe_getmembers(module):
"""Need this because some modules are lazily loaded and we can't get the members."""
"""Need this because some modules are lazily loaded and we can't get the members.
e.g. ibis.
"""
try:
return inspect.getmembers(module)
except Exception as e:
Expand Down
2 changes: 1 addition & 1 deletion ui/sdk/src/hamilton_sdk/tracking/ibis_stats.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def base_data_type_mapping(data_type: core.DataType) -> str:


base_schema = {
# we can't get all of these about a pyspark dataframe
# we can't get all of these about an ibis dataframe
"base_data_type": None,
# 'count': 0,
"data_type": None,
Expand Down

0 comments on commit 683e657

Please sign in to comment.