improve favicon inversion (#114) #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
I'm guessing I have merged this via e901efc and dda4587 and 7f8d4d3 It is live now in the dev version. Please test it and let me know if I missed something. |
|
Yes, and I improved more by receiving your comment. In this PR, I merged those commits with |
Croydon
added
cat:accessibility
|
@Croydon I'm not sure why I was assigned 😅 What should I do? |
|
@mmktomato Nothing specifically. I'm just assigning always the person/people (mainly) responsible for the work. Private life keeps me busy right now but I will soon merge this into a beta version in the |
|
I see. Thanks!! |
|
It has been a minute. Sorry! Do you remember the details of what exactly was improved here? Is the threshold when it inverts or not better in this version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recreated this pull request.
original pull request: #222