Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better display for dark favicons in the dark theme #114

Closed
sabi0 opened this issue Aug 30, 2017 · 3 comments
Closed

Better display for dark favicons in the dark theme #114

sabi0 opened this issue Aug 30, 2017 · 3 comments

Comments

@sabi0
Copy link

sabi0 commented Aug 30, 2017

Dakr favicons (e.g. GitHub's one) are poorly visible when using dark theme. They should be inversed or highlighted in some other way.

Here is an example how they did it in Opera:
https://blogs.opera.com/desktop/2017/06/opera-47-beta/

@Croydon
Copy link
Owner

Croydon commented Mar 19, 2018

Does someone know a JavaScript library which can do the entire image manipulation?

I won't have time to write something on my own for likely a long time.

Integrating something existing should be fairly easy.

A library should somehow calculate the brightness of the entire icon, then decide if the colors needs to get inversed. Or something along these lines.

@Croydon Croydon added this to the until 1.0.0 milestone Apr 18, 2018
mmktomato added a commit to mmktomato/vertical-tabs-reloaded that referenced this issue Dec 16, 2018
@Croydon Croydon modified the milestones: until 1.0.0, 0.13.0 Dec 17, 2018
Croydon pushed a commit that referenced this issue Dec 17, 2018
Croydon added a commit that referenced this issue Dec 17, 2018
Give the themes the opportunity to react on dark/light favicons as they want

+

remove tab-icon-image-dark class when it is not anylonger the case
Croydon added a commit that referenced this issue Dec 17, 2018
Trashhold decreased from 128 to 108

Refactoring in the future might add theme utils and a isDark() function, so we don't need to change third-party libs.
@Croydon Croydon added the cat:accessibility Improvements for accessibility label Dec 17, 2018
mmktomato added a commit to mmktomato/vertical-tabs-reloaded that referenced this issue Dec 17, 2018
mmktomato added a commit to mmktomato/vertical-tabs-reloaded that referenced this issue Dec 17, 2018
mmktomato added a commit to mmktomato/vertical-tabs-reloaded that referenced this issue Dec 17, 2018
mmktomato pushed a commit to mmktomato/vertical-tabs-reloaded that referenced this issue Feb 15, 2019
mmktomato added a commit to mmktomato/vertical-tabs-reloaded that referenced this issue Feb 15, 2019
@Croydon
Copy link
Owner

Croydon commented Mar 26, 2020

This will finally land in the 0.13.0 release that I'm planning for the next few days

I might improve it in later releases further, see #224

@Croydon
Copy link
Owner

Croydon commented Mar 26, 2020

Closing.

Fixed by e901efc, dda4587, 7f8d4d3

Thanks @mmktomato!

@Croydon Croydon closed this as completed Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants