-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better display for dark favicons in the dark theme #114
Comments
Does someone know a JavaScript library which can do the entire image manipulation? I won't have time to write something on my own for likely a long time. Integrating something existing should be fairly easy. A library should somehow calculate the brightness of the entire icon, then decide if the colors needs to get inversed. Or something along these lines. |
Give the themes the opportunity to react on dark/light favicons as they want + remove tab-icon-image-dark class when it is not anylonger the case
Trashhold decreased from 128 to 108 Refactoring in the future might add theme utils and a isDark() function, so we don't need to change third-party libs.
This will finally land in the 0.13.0 release that I'm planning for the next few days I might improve it in later releases further, see #224 |
Closing. Fixed by e901efc, dda4587, 7f8d4d3 Thanks @mmktomato! |
Dakr favicons (e.g. GitHub's one) are poorly visible when using dark theme. They should be inversed or highlighted in some other way.
Here is an example how they did it in Opera:
https://blogs.opera.com/desktop/2017/06/opera-47-beta/
The text was updated successfully, but these errors were encountered: