Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] - Refactor SoundJS lib with good practices #303

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[WIP] - Refactor SoundJS lib with good practices #303

wants to merge 7 commits into from

Commits on Jun 28, 2018

  1. remove excessive commentaries

    @calebesantos
    calebesantos committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    3450be9 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2018

  1. create new classes with single responsability

    @calebesantos
    calebesantos committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    6e6e001 View commit details
    Browse the repository at this point in the history

  2. rename any variables

    @calebesantos
    calebesantos committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    79ff82b View commit details
    Browse the repository at this point in the history

  3. remove magic number

    @calebesantos
    calebesantos committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    28231c3 View commit details
    Browse the repository at this point in the history

  4. rename any variables

    @calebesantos
    calebesantos committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    441c23c View commit details
    Browse the repository at this point in the history

  5. add and improve defensive programming

    @calebesantos
    calebesantos committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    187a0d2 View commit details
    Browse the repository at this point in the history

  6. create new functions to decrease the coupling

    @calebesantos
    calebesantos committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    df37cad View commit details
    Browse the repository at this point in the history