Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - Refactor SoundJS lib with good practices #303

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[WIP] - Refactor SoundJS lib with good practices #303

wants to merge 7 commits into from

Conversation

calebesantos
Copy link

@calebesantos calebesantos commented Jun 29, 2018

Hello, I have a college evaluation to help with good coding practices a repository.
I hope my changes helps xD

Best practices or guidelines related to:

  • Functions
  • Variables, objects or data structures
  • Defensive programming or error handling
  • Classes

@gSkinner-Blair
Copy link
Contributor

Hey there! Thanks for the contribution! We'll review this when we get a chance to see if there's good value in these changes. Unfortunately, we might not get to it right away - vetting these changes might be a fairly large task given the amount of them, and things like needing to make sure this works with our autodocs etc. Right now our priority on the CreateJS libraries is working on the 2.0 versions, which in the case of SoundJS 2.0, is a complete rewrite.

@calebesantos
Copy link
Author

Thanks for review! Your feedback was very important!

@mymomscrazy
Copy link

Genius reply. Thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants