[Backport release/1.7] CASMTRIAGE-7627 ignore non-csm failed backups #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mharding-hpe
approved these changes
Jan 8, 2025
jacobsalmela
force-pushed
the
backport/655-to-release/1.7
branch
from
00b28cb to
1f77747
Compare
`velero_backups_check.sh` causes a test failure intermittently on
in-house sytems, often from other products such as PBS or Slingshot.
While they may be valid failures, the CSM product is not at fault, so
those should not trigger a test failure.
for this commit, I modified it to check only for failed vault backups
since that is more pertinent to CSM itself.
I moved the code that was previously run with a pipe and checking the
exit code to instead make a temp file, use a single jq command to query
it, and then fail if there are any failed vault backups.
if we determine other backups should be checked, we can add those to
that jq command.
Signed-off-by: Jacob Salmela <[email protected]>
(cherry picked from commit 164e86d)
Signed-off-by: Jacob Salmela <[email protected]>
mharding-hpe
force-pushed
the
backport/655-to-release/1.7
branch
from
1f77747 to
76d19f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #655