CASMTRIAGE-7627 ignore non-csm failed backups #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsalmela
requested review from
mharding-hpe,
kimjensen-hpe and
spillerc-hpe
jacobsalmela
force-pushed
the
CASMTRIAGE-7627
branch
2 times, most recently
from
0733f5a to
164e86d
Compare
mharding-hpe
approved these changes
Jan 8, 2025
|
/backport release/1.7 |
|
Backporting into branch release/1.7 was successful. New PR: #658 |
kimjensen-hpe
approved these changes
Jan 8, 2025
`velero_backups_check.sh` causes a test failure intermittently on
in-house sytems, often from other products such as PBS or Slingshot.
While they may be valid failures, the CSM product is not at fault, so
those should not trigger a test failure.
for this commit, I modified it to check only for failed vault backups
since that is more pertinent to CSM itself.
I moved the code that was previously run with a pipe and checking the
exit code to instead make a temp file, use a single jq command to query
it, and then fail if there are any failed vault backups.
if we determine other backups should be checked, we can add those to
that jq command.
Signed-off-by: Jacob Salmela <[email protected]>
jacobsalmela
force-pushed
the
CASMTRIAGE-7627
branch
from
7030f6a to
83fcf97
Compare
spillerc-hpe
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
velero_backups_check.shcauses a test failure intermittently on in-house sytems, often from other products such as PBS or Slingshot. While they may be valid failures, the CSM product is not at fault, so those should not trigger a test failure.for this commit, I modified it to check only for failed vault backups since that is more pertinent to CSM itself.
I moved the code that was previously run with a pipe and checking the exit code to instead make a temp file, use a single jq command to query it, and then fail if there are any failed vault backups.
if we determine other backups should be checked, we can add those to
that jq command.