Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: swap toRemove & toAdd in deltaExtensions #227

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix: swap toRemove & toAdd in deltaExtensions #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/service-override/extensions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,14 +433,14 @@ export class SimpleExtensionService extends AbstractExtensionService implements

public async deltaExtensions (toAdd: IExtensionWithExtHostKind[], toRemove: IExtension[]): Promise<void> {
const extHostPicker = (this._extensionHostKindPicker as LocalBrowserExtensionHostKindPicker)
for (const extension of toRemove) {
extHostPicker.removeForcedExtensionHostKind(extension.identifier.id)
}
for (const extension of toAdd) {
if (extension.extHostKind != null) {
extHostPicker.setForcedExtensionHostKind(extension.identifier.id, extension.extHostKind)
}
}
for (const extension of toRemove) {
extHostPicker.removeForcedExtensionHostKind(extension.identifier.id)
}

await this._handleDeltaExtensions(new DeltaExtensionsQueueItem(toAdd, toRemove))
}
Expand Down